Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perl: 5.30.3 -> 5.32.0 #95012

Merged
merged 1 commit into from Aug 30, 2020
Merged

perl: 5.30.3 -> 5.32.0 #95012

merged 1 commit into from Aug 30, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Aug 9, 2020 •
edited

This PR updates perl to 5.32.0

Replaces #93036

  • perl and perl532 set to 5.32.0
  • perldevelop set to 5.33 5.32.0 5.33.1
  • perl-cross updated to latest with support for 5.33.1
  • perl528 removed
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from volth and aanderse August 9, 2020 16:10
@stigtsp
Copy link
Member Author

stigtsp commented Aug 9, 2020

@GrahamcOfBorg build perl530
@GrahamcOfBorg build perl
@GrahamcOfBorg build perldevel
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl530
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perldevel
@GrahamcOfBorg build pkgsMusl.perl530
@GrahamcOfBorg build pkgsMusl.perl
@GrahamcOfBorg build pkgsMusl.perldevel
@GrahamcOfBorg build pkgsi686Linux.perl530
@GrahamcOfBorg build pkgsi686Linux.perl
@GrahamcOfBorg build pkgsi686Linux.perldevel

@stigtsp stigtsp marked this pull request as draft August 9, 2020 16:12
@stigtsp
Copy link
Member Author

stigtsp commented Aug 9, 2020 •
edited

perldevel at 5.33.0 is not supported by the upstream perl-cross yet. I'm inclined to set perldevel to 5.32.0 until support is available, as in the original PR?

@ofborg ofborg bot requested review from np, andir, edolstra, Izorkin and lovek323 August 9, 2020 18:06
@stigtsp
Copy link
Member Author

stigtsp commented Aug 9, 2020

@GrahamcOfBorg build perl530
@GrahamcOfBorg build perl
@GrahamcOfBorg build perldevel
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl530
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perl
@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perldevel
@GrahamcOfBorg build pkgsMusl.perl530
@GrahamcOfBorg build pkgsMusl.perl
@GrahamcOfBorg build pkgsMusl.perldevel
@GrahamcOfBorg build pkgsi686Linux.perl530
@GrahamcOfBorg build pkgsi686Linux.perl
@GrahamcOfBorg build pkgsi686Linux.perldevel

PS: I'm unable to trigger Darwin builds

@stigtsp stigtsp marked this pull request as ready for review August 9, 2020 21:50
@jonringer jonringer added this to To Do in 20.09 Blockers via automation Aug 15, 2020
@jonringer jonringer moved this from To Do to In progress in 20.09 Blockers Aug 15, 2020
@stigtsp
perl: 5.30.3 -> 5.32.0, perldevel: 5.32.0-RC0 -> 5.33.1
37d6661 
Co-authored-by: volth <volth@volth.com>
@stigtsp
Copy link
Member Author

stigtsp commented Aug 30, 2020

Updated perldevel to 5.33.1, and perl-cross to the latest version which supports it.

@stigtsp
Copy link
Member Author

stigtsp commented Aug 30, 2020

@GrahamcOfBorg build pkgsCross.aarch64-multiplatform.perldevel
@GrahamcOfBorg build perldevel

@ofborg ofborg bot removed the request for review from lovek323 August 30, 2020 12:58
@FRidh
Copy link
Member

FRidh commented Aug 30, 2020

tested cross builds and they succeeded.

@FRidh FRidh merged commit 5aef482 into NixOS:staging Aug 30, 2020
20.09 Blockers automation moved this from In progress to Done Aug 30, 2020
@worldofpeace worldofpeace removed this from Done in 20.09 Blockers Oct 5, 2020
@worldofpeace worldofpeace added this to In progress in 20.09 Blockers via automation Oct 5, 2020
@worldofpeace worldofpeace moved this from In progress to Done in 20.09 Blockers Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

@np np Awaiting requested review from np

@andir andir Awaiting requested review from andir

@edolstra edolstra Awaiting requested review from edolstra

@Izorkin Izorkin Awaiting requested review from Izorkin

Assignees
No one assigned
Labels
1.severity: mass-rebuild 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
No open projects
20.09 Blockers
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @FRidh