Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drone-cli: 1.2.1 -> 1.2.2 #95056

Merged
merged 1 commit into from Aug 10, 2020
Merged

drone-cli: 1.2.1 -> 1.2.2 #95056

merged 1 commit into from Aug 10, 2020

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Aug 10, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kampka
Copy link
Contributor Author

kampka commented Aug 10, 2020

@GrahamcOfBorg build drone-cli

@kampka kampka requested a review from Mic92 August 10, 2020 08:42
@Mic92
Copy link
Member

Mic92 commented Aug 10, 2020

Result of nixpkgs-review pr 95056 1

1 package built:
- drone-cli

@Mic92 Mic92 merged commit c6975c4 into NixOS:master Aug 10, 2020
@ofborg ofborg bot requested review from bricewge and kalbasit August 10, 2020 08:59
@Mic92 Mic92 mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@bricewge bricewge Awaiting requested review from bricewge

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kampka @Mic92