Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a constraint is selected, prioritize it for starting a drag #174

Closed
wpwrak opened this issue Jan 28, 2017 · 11 comments · Fixed by #672
Closed

if a constraint is selected, prioritize it for starting a drag #174

wpwrak opened this issue Jan 28, 2017 · 11 comments · Fixed by #672

Comments

@wpwrak
Copy link
Contributor

wpwrak commented Jan 28, 2017

Lately, I'm having a lot of difficulties dragging distances. Selecting them is fine. I'm not entirely sure if it's because I unlearned some movement that happens to work better, or simply because my designs are getting more crowded.

When trying to drag a distance, I typically aim first for the text. If that doesn't work, I try to get the line(s) to the item being sized.

Perhaps the dragging function could, when deciding what to do with the drag movement, give preference to the item already selected.

@whitequark
Copy link
Contributor

@wpwrak do you have any sketch where this is reproducible? Please also post a screenshot with position/zoom settings that reproduce the issue.

@wpwrak
Copy link
Contributor Author

wpwrak commented Jan 28, 2017

Here is one:
http://downloads.qi-hardware.com/people/werner/slvs/drag-diam-hard.png
The cursor (alas, xwd can't show it) is over the center of the circle-with-slash. Pressing the left button and dragging does nothing.

The .slvs is simple enough:
http://downloads.qi-hardware.com/people/werner/slvs/drag-diam-hard.slvs

@whitequark whitequark changed the title distances can be hard to drag if a constraint is selected, prioritize it for starting a drag Jan 28, 2017
@whitequark
Copy link
Contributor

confirmed

@Evil-Spirit
Copy link
Collaborator

Evil-Spirit@3c8cc2e

@baryluk
Copy link

baryluk commented Jan 16, 2020

Same here. I have a line-distance constrain selected, but I can't drag it, because it is overlapping with line behind it I guess. It happens even if the constrain is a reference value.

I am using git master 16c5fa6

@baryluk
Copy link

baryluk commented Jan 16, 2020

@Evil-Spirit I can confirm that the patch from Evil-Spirit@3c8cc2e fixes the issue.

I do not know if it is the correct solution, but it does fixes this particular problem for me.

The patch is not really in mergable state tho. It should just remove the commented code, not comment it out. :D Or fix the logic there, otherwise it looks a bit more like a hack.

@phkahler
Copy link
Member

IMHO that patch is no good. It eliminates the ability to drag entities from prior groups. Normally if you extrude a rectangle you can push or pull the "new" end to change the length, while dragging points or lines of the original rectangle can change the width or height. The patch eliminates the option for the later - resizing the underlying sketch from the extrusion group.

@phkahler
Copy link
Member

BTW if it's the same this is really easy to reproduce. Draw a circle, press "d" and type in 10. The diameter will be positioned right in the middle of the circle and will be really hard to move. It highlights correctly when hovered, but often will refuse to drag. Is worse with small circles, hence typing 10 for diameter on default view.

@phkahler
Copy link
Member

phkahler commented Aug 9, 2020

Can anyone confirm the fix in PR #672 fixes this on Windows and OSX? It's good on Linux.

@nabijaczleweli
Copy link
Contributor

nabijaczleweli commented Aug 9, 2020

Works for me on Windows

@phkahler
Copy link
Member

@nabijaczleweli Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants