Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bind: formatted with nixpkgs-fmt #95050

Merged
merged 1 commit into from May 10, 2021
Merged

nixos/bind: formatted with nixpkgs-fmt #95050

merged 1 commit into from May 10, 2021

Conversation

paumr
Copy link
Contributor

@paumr paumr commented Aug 10, 2020

Motivation for this change

Moved changes after formatting (with nixpkgs-fmt) to separate branch (as requested in #87973)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@paumr paumr requested a review from peti as a code owner August 10, 2020 07:16
Ma27
Ma27 reviewed Aug 10, 2020
View reviewed changes
nixos/modules/services/networking/bind.nix Outdated Show resolved Hide resolved
nixos/modules/services/networking/bind.nix Outdated Show resolved Hide resolved
@paumr
Copy link
Contributor Author

paumr commented Aug 10, 2020

updated initial PR to use nixpkgs-fmt version 0.9.0

@paumr paumr mentioned this pull request Aug 14, 2020
Closed
10 tasks
@raboof
Copy link
Member

raboof commented May 1, 2021

I'm afraid this is now conflicting with master. Do you want me to give rebasing a try or would you prefer to pick this up yourself?

@paumr
Copy link
Contributor Author

paumr commented May 8, 2021

I picked it up, I:

  • rebased the branch on the current master
  • ran nixpkgs-fmt with the current version and squashed the commits
  • removed literalExample since the example isn't a string anymore

@fricklerhandwerk
Copy link
Contributor

LGTM.

@SuperSandro2000 SuperSandro2000 merged commit f0bb4f0 into NixOS:master May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@Ma27 Ma27 Ma27 left review comments

@raboof raboof raboof approved these changes

@peti peti Awaiting requested review from peti peti is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paumr @raboof @fricklerhandwerk @alyssais @Ma27 @SuperSandro2000