Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python37Packages.PyChromecast: 6.0.0 -> 7.1.0 #92502

Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jul 6, 2020

Semi-automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python3.7-PyChromecast/versions.

meta.description for python37Packages.PyChromecast is: "Library for Python 3.4+ to communicate with the Google Chromecast"

meta.homepage for python37Packages.PyChromecast is: "https://github.com/balloob/pychromecast"

meta.changelog for python37Packages.PyChromecast is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
catt
gnomecast
python37Packages.PyChromecast
python38Packages.PyChromecast
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/nchyf6sckyxxxgjylsf6bnbllsr4iv2b-python3.7-PyChromecast-7.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python37Packages.PyChromecast https://github.com/r-ryantm/nixpkgs/archive/5d66efb839653ea52db25b8f5da9d6f2a32ef84a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/nchyf6sckyxxxgjylsf6bnbllsr4iv2b-python3.7-PyChromecast-7.1.0
ls -la /nix/store/nchyf6sckyxxxgjylsf6bnbllsr4iv2b-python3.7-PyChromecast-7.1.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

4 packages built:
- catt
- gnomecast
- python37Packages.PyChromecast
- python38Packages.PyChromecast

Maintainer pings

cc @abbradar for testing.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92502 1

4 packages built: - catt - gnomecast - python37Packages.PyChromecast - python38Packages.PyChromecast

@jonringer jonringer merged commit 29f08dc into NixOS:master Jul 7, 2020
@r-ryantm r-ryantm deleted the auto-update/python3.7-PyChromecast branch July 8, 2020 01:38
@bqv
Copy link
Contributor

bqv commented Aug 26, 2020

It seems this change broke pkgs.catt at runtime, due to this skorokithakis/catt#271

@jonringer
Copy link
Contributor

not sure how i feel about reverting this, there's a few other packages which use it

pkgs/servers/home-assistant/component-packages.nix
110:    "cast" = ps: with ps; [ aiohttp-cors hass-nabucasa PyChromecast zeroconf];

pkgs/development/python-modules/pychromecast/default.nix
4:  pname = "PyChromecast";

pkgs/top-level/python-packages.nix
1227:  PyChromecast = callPackage ../development/python-modules/pychromecast { };

pkgs/applications/audio/sublime-music/default.nix
45:   ++ lib.optional chromecastSupport PyChromecast

pkgs/applications/video/gnomecast/default.nix
15:    PyChromecast bottle pycaption paste html5lib pygobject3 dbus-python

pkgs/applications/video/catt/default.nix
3:, PyChromecast
19:    youtube-dl PyChromecast click ifaddr requests

@bqv
Copy link
Contributor

bqv commented Aug 27, 2020

For those landing here in the future; this gets something built that works:

final: prev: {
  catt = (prev.catt.overridePythonAttrs (drv: {
    doInstallCheck = false;
  })).override {
    PyChromecast = prev.python3Packages.PyChromecast.overridePythonAttrs (drv: rec {
      version = "6.0.0";
      src = prev.python3Packages.fetchPypi {
        inherit (drv) pname;
        inherit version;
        sha256 = "Fb6q/bFViFeURD2Z+mh6J4fYuti6RA7NoQu3K9bIyBU=";
      };
    });
  };
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants