Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glances: remove batinfo dependency #92443

Merged
merged 1 commit into from Jul 7, 2020
Merged

glances: remove batinfo dependency #92443

merged 1 commit into from Jul 7, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jul 6, 2020

Motivation for this change

batinfo is no longer in the list of optional dependencies since nicolargo/glances@fd45d41. batinfo seems to no longer be maintained and also doesn't work on macOS, causing the sensors plugin of glances to fail. glances automatically uses psutil when batinfo is not available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
glances: remove batinfo dependency
bdd8daa 
batinfo is no longer in the list of optional dependencies since nicolargo/glances@fd45d41. batinfo seems to no longer be maintained and also doesn't work on macOS, causing the sensors plugin of glances to fail. glances automatically uses psutil when batinfo is not available.
@ofborg ofborg bot requested review from jonringer and primeos July 6, 2020 10:39
jonringer
jonringer approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 92443 1

1 package built: - glances

@jonringer jonringer merged commit 66bed37 into NixOS:master Jul 7, 2020
@Luflosi Luflosi deleted the glances-remove-batinfo branch July 7, 2020 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @jonringer