Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpvScripts.sponsorblock: init #92507

Merged
merged 1 commit into from Aug 20, 2020
Merged

mpvScripts.sponsorblock: init #92507

merged 1 commit into from Aug 20, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jul 6, 2020

Motivation for this change

This creates a package for the sponsorblock mpv script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien pacien mentioned this pull request Jul 6, 2020
Open
@pacien pacien changed the title mpvScripts.sponsorblock: init at f71e49e (2020-07-05) [WIP] mpvScripts.sponsorblock: init Jul 7, 2020
@pacien pacien marked this pull request as draft July 7, 2020 21:26
@pacien pacien force-pushed the mpvscripts-sponsorblock-init branch 2 times, most recently from 6a7a82d to 470130c Compare July 14, 2020 11:30
@pacien pacien changed the title [WIP] mpvScripts.sponsorblock: init mpvScripts.sponsorblock: init Jul 14, 2020
@pacien pacien marked this pull request as ready for review July 14, 2020 11:31
danielfullmer
danielfullmer suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@danielfullmer danielfullmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've built and tested this package briefly, with the suggested changes. It does seem to be working properly on the youtube videos I tried. Thanks!

pkgs/applications/video/mpv/scripts/sponsorblock.nix Outdated Show resolved Hide resolved
pkgs/applications/video/mpv/scripts/sponsorblock.nix Outdated Show resolved Hide resolved
pkgs/applications/video/mpv/scripts/sponsorblock.nix Outdated Show resolved Hide resolved
@pacien pacien force-pushed the mpvscripts-sponsorblock-init branch 2 times, most recently from 179ee4c to b7ebb43 Compare July 22, 2020 10:26
@mweinelt mweinelt mentioned this pull request Jul 23, 2020
Closed
10 tasks
@pacien pacien force-pushed the mpvscripts-sponsorblock-init branch from b7ebb43 to 6b7c3f1 Compare July 26, 2020 20:01
@pacien pacien force-pushed the mpvscripts-sponsorblock-init branch from 6b7c3f1 to 1d18e35 Compare August 7, 2020 12:47
@Lassulus Lassulus merged commit d90488a into NixOS:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelgrf samuelgrf samuelgrf left review comments

@danielfullmer danielfullmer danielfullmer approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@roosemberth roosemberth Awaiting requested review from roosemberth

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pacien @mweinelt @danielfullmer @roosemberth @samuelgrf @Lassulus