Change document policy parser to use structured header dictionary #24460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2281104
branch
2 times, most recently
from
fe58814
to
d63aa97
Compare
This CL is based on the spec change on https://github.com/w3c/webappsec-feature-policy/pull/388/files?short_path=1a56774. Since the parameter names are removed in this change, feature names will have to change so that they remain meaningful. This will be addressed in follow-up CLs. Change-Id: Ic87dcb5bf26e440dd5041ae31d7b248e7d85d93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281104 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#786929}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2281104
branch
from
d63aa97
to
424796e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL is based on the spec change on
https://github.com/w3c/webappsec-feature-policy/pull/388/files?short_path=1a56774.
Since the parameter names are removed in this change, feature names
will have to change so that they remain meaningful. This will be
addressed in follow-up CLs.
Change-Id: Ic87dcb5bf26e440dd5041ae31d7b248e7d85d93a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281104
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#786929}