Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpfshell: 0.8.1 -> unstable-2020-04-11 #92531

Merged
merged 1 commit into from Dec 31, 2020
Merged

mpfshell: 0.8.1 -> unstable-2020-04-11 #92531

merged 1 commit into from Dec 31, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 6, 2020

Update to current git master.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata requested a review from oxzi July 6, 2020 23:40
oxzi
oxzi approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

stigtsp
stigtsp requested changes Sep 25, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Sorry for the long wait.

Tested the executable, runs OK.

pkgs/development/tools/mpfshell/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 92531 run on x86_64-linux 1

1 package built:
  • mpfshell
Ran 0 tests in 0.000s

Please add doCheck = false; and a pythonImportsCheck.

@mmilata
Copy link
Member Author

mmilata commented Dec 28, 2020

Updated & rebased. TIL pythonImportsCheck exists.

@mweinelt mweinelt merged commit f1079ad into NixOS:master Dec 31, 2020
@mmilata mmilata deleted the mpfshell-2020-04-11 branch December 31, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@stigtsp stigtsp stigtsp requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@oxzi oxzi oxzi approved these changes

Assignees
No one assigned
Labels
6.topic: hardware 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmilata @SuperSandro2000 @stigtsp @mweinelt @oxzi