Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gscan2pdf: 2.6.5 -> 2.8.0 #92471

Merged
merged 1 commit into from Jul 7, 2020
Merged

gscan2pdf: 2.6.5 -> 2.8.0 #92471

merged 1 commit into from Jul 7, 2020

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jul 6, 2020

Motivation for this change

This updates gscan2pdf to the latest available version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Successfully scanned a page
    • Successfully exported to PDF
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bump looks good.

Result of nixpkgs-review pr 92471 1

1 package built:
- gscan2pdf

Note though that scanimage is assumed to be in the environment, see lib/perl5/site_perl/5.30.3/Gscan2pdf/Frontend/CLI.pm. @pacien probably ${saneBackends}/bin should be added to PATH as well while wrapping?

@danieldk danieldk merged commit 70b5f95 into NixOS:master Jul 7, 2020
@pacien pacien mentioned this pull request Jul 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @danieldk