New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define plugins hooks as classes #1383
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Jul 6, 2020
adisbladis
force-pushed
the
plugin-classes
branch
from
July 7, 2020 12:13
3fdcf82
to
863c16d
Compare
adisbladis
force-pushed
the
plugin-classes
branch
2 times, most recently
from
July 8, 2020 11:14
6566698
to
8892e7f
Compare
adisbladis
added a commit
to nix-community/nixos-modules-contrib
that referenced
this pull request
Jul 8, 2020
adisbladis
added a commit
to NixOS/nixops-aws
that referenced
this pull request
Jul 8, 2020
adisbladis
added a commit
to NixOS/nixops-aws
that referenced
this pull request
Jul 8, 2020
adisbladis
added a commit
to nix-community/nixops-encrypted-links
that referenced
this pull request
Jul 9, 2020
adisbladis
added a commit
to nix-community/nixops-gce
that referenced
this pull request
Jul 9, 2020
adisbladis
added a commit
to nix-community/nixops-libvirtd
that referenced
this pull request
Jul 9, 2020
adisbladis
added a commit
to nix-community/nixops-vbox
that referenced
this pull request
Jul 9, 2020
adisbladis
force-pushed
the
plugin-classes
branch
from
July 9, 2020 14:07
080013b
to
881c0b4
Compare
grahamc
reviewed
Jul 9, 2020
grahamc
reviewed
Jul 9, 2020
grahamc
reviewed
Jul 9, 2020
grahamc
reviewed
Jul 9, 2020
grahamc
reviewed
Jul 9, 2020
This is a better way to deal with plugins as we can statically type each individual function, something not possible with pluggy hooks.
It can be useful for plugins to introspect/use exactly what was passe by Nix.
adisbladis
force-pushed
the
plugin-classes
branch
from
July 9, 2020 14:52
8ff49f4
to
e498a6c
Compare
It's much easier to notice that NeatCloud needs replacing than My.
grahamc
approved these changes
Jul 9, 2020
adisbladis
added a commit
to nix-community/nixos-modules-contrib
that referenced
this pull request
Jul 10, 2020
Use the NixOps class interface from NixOS/nixops#1383
adisbladis
added a commit
to NixOS/nixops-aws
that referenced
this pull request
Jul 10, 2020
Use the NixOps class interface from NixOS/nixops#1383
adisbladis
added a commit
to nix-community/nixops-gce
that referenced
this pull request
Jul 10, 2020
adisbladis
added a commit
to nix-community/nixops-libvirtd
that referenced
this pull request
Jul 10, 2020
adisbladis
added a commit
to nix-community/nixops-gce
that referenced
this pull request
Jul 10, 2020
Use the NixOps class interface from NixOS/nixops#1383
adisbladis
added a commit
to nix-community/nixops-vbox
that referenced
this pull request
Jul 10, 2020
Use the NixOps class interface from NixOS/nixops#1383
adisbladis
added a commit
to nix-community/nixops-libvirtd
that referenced
this pull request
Jul 13, 2020
Use the NixOps class interface from NixOS/nixops#1383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a better way to deal with plugins as we can statically type each individual function, something not possible with pluggy hooks.