Construct StyleResolver in StyleEngine constructor. #24454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 6, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2270209
branch
2 times, most recently
from
4455fda
to
7a18f8f
Compare
Years ago, the StyleResolver was deleted and re-created for certain style sheet changes. The current lifetime of the StyleResolver is that it is created once on first EnsureStyleResolver and only freed when the StyleEngine is disposed. Instead of checking if it needs to be constructed every time we access it, create it as part of constructing the StyleEngine. We don't create it for documents without a Frame for which we should not use the StyleResolver. Change-Id: I1f1d2ef322d2599737f584191550f769dcf6828e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270209 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#787158}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2270209
branch
from
7a18f8f
to
b80305f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Years ago, the StyleResolver was deleted and re-created for certain
style sheet changes. The current lifetime of the StyleResolver is that it
is created once on first EnsureStyleResolver and only freed when the
StyleEngine is disposed. Instead of checking if it needs to be
constructed every time we access it, create it as part of constructing
the StyleEngine.
We don't create it for documents without a Frame for which we should not
use the StyleResolver.
Change-Id: I1f1d2ef322d2599737f584191550f769dcf6828e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270209
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787158}