Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firestarter: v1.7.4 fix commit hash #92456

Merged
merged 1 commit into from Jul 6, 2020
Merged

firestarter: v1.7.4 fix commit hash #92456

merged 1 commit into from Jul 6, 2020

Conversation

marenz2569
Copy link
Member

@marenz2569 marenz2569 commented Jul 6, 2020 •
edited

Motivation for this change

Firestarter has been added to Nixpkgs before it was a public release. The tag v1.7.4 got involuntary into a commit. The actual release was a few months later.

Things done

I have changed the commit hash to the right one.
Fixes #91866

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC @astro

@ofborg ofborg bot requested a review from astro July 6, 2020 13:59
@bbigras
Copy link
Contributor

bbigras commented Jul 6, 2020

@GrahamcOfBorg build firestarter

@grahamc
Copy link
Member

grahamc commented Jul 6, 2020

Ofborg and hydra won't build this because it has unfree dependencies.

@grahamc grahamc merged commit 3534465 into NixOS:master Jul 6, 2020
@marenz2569 marenz2569 deleted the fix-firestarter-v1.7.4-hash branch July 6, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astro astro Awaiting requested review from astro

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

firestarter: hash mismatch
3 participants
@marenz2569 @bbigras @grahamc