Pointing to correct branch for different channels

NixOS · Jul 6, 2020 · c256b4b · c256b4b
1 parent 46c7eaa
commit c256b4b
Showing 1 changed file with 25 additions and 12 deletions.
diff --git a/src/Page/Options.elm b/src/Page/Options.elm
@@ -141,22 +141,23 @@ viewSuccess channel show result =
             , tbody
                 []
                 (List.concatMap
-                    (viewResultItem show)
+                    (viewResultItem channel show)
                     result.hits.hits
                 )
             ]
         ]
 
 
 viewResultItem :
-    Maybe String
+    String
+    -> Maybe String
     -> Search.ResultItem ResultItemSource
     -> List (Html Msg)
-viewResultItem show item =
+viewResultItem channel show item =
     let
         packageDetails =
             if Just item.source.name == show then
-                [ td [ colspan 1 ] [ viewResultItemDetails item ]
+                [ td [ colspan 1 ] [ viewResultItemDetails channel item ]
                 ]
 
             else
@@ -189,9 +190,10 @@ viewResultItem show item =
 
 
 viewResultItemDetails :
-    Search.ResultItem ResultItemSource
+    String
+    -> Search.ResultItem ResultItemSource
     -> Html Msg
-viewResultItemDetails item =
+viewResultItemDetails channel item =
     let
         default =
             "Not given"
@@ -211,14 +213,25 @@ viewResultItemDetails item =
         asLink value =
             a [ href value ] [ text value ]
 
-        -- TODO: this should take channel into account as well
-        githubUrlPrefix =
-            "https://github.com/NixOS/nixpkgs-channels/blob/nixos-unstable/"
+        githubUrlPrefix branch =
+            "https://github.com/NixOS/nixpkgs-channels/blob/" ++ branch ++ "/"
+
+        cleanPosition value =
+            if String.startsWith "source/" value then
+                String.dropLeft 7 value
+
+            else
+                value
 
         asGithubLink value =
-            a
-                [ href <| githubUrlPrefix ++ (value |> String.replace ":" "#L") ]
-                [ text <| value ]
+            case Search.channelDetailsFromId channel of
+                Just channelDetails ->
+                    a
+                        [ href <| githubUrlPrefix channelDetails.branch ++ (value |> String.replace ":" "#L") ]
+                        [ text <| value ]
+
+                Nothing ->
+                    text <| cleanPosition value
 
         wrapped wrapWith value =
             case value of