Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to install nix on non-systemd systems. #3788

Merged
merged 2 commits into from Jul 31, 2020

Conversation

crinklywrappr
Copy link
Contributor

@crinklywrappr crinklywrappr commented Jul 7, 2020

I cleaned up and moved my changes from this post into the repo. The new install script has very few changes from the original install-multi-user.sh.

I didn't test to make sure this ran, and I'm not sure if additional changes are required, eg changes to a makefile to get the script to the right location in the tarball. However, this is almost a direct copy of what I ran on Artix.

I will keep up with the pull request and respond to CRs, and anything else required to get this merged.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/install-nix-daemon-on-non-systemd-init/7911/4

@edolstra
Copy link
Member

edolstra commented Jul 7, 2020

We really shouldn't have another install script that is nearly identical to scripts/install-multi-user.sh. That's a maintainability mess. Isn't it possible to add support for non-systemd systems to scripts/install-multi-user.sh?

@crinklywrappr
Copy link
Contributor Author

Sure. I'll change it.

@crinklywrappr
Copy link
Contributor Author

Someone may need to enlighten me as to what went wrong here. It appears the installation worked, but one of the tests broke.

@edolstra
Copy link
Member

edolstra commented Jul 8, 2020

Hm, I don't think that failure has anything to do with your changes...

@virusdave
Copy link
Contributor

Wow, i JUST started working on something similar today. Thanks for doing the work for me! :)

@edolstra edolstra merged commit 3e30710 into NixOS:master Jul 31, 2020
@edolstra
Copy link
Member

Thanks, merged!

abathur added a commit to abathur/nix that referenced this pull request Sep 11, 2020
Some of the changes in NixOS#3788 to support non-systemd Nix installs
don't appear to be aware that the darwin installer exists, which
resulted in some skipped steps and inappropriate instructions.
abathur added a commit to abathur/nix that referenced this pull request Sep 24, 2020
Some of the changes in NixOS#3788 to support non-systemd Nix installs
don't appear to be aware that the darwin installer exists, which
resulted in some skipped steps and inappropriate instructions.
abathur added a commit to abathur/nix that referenced this pull request Oct 19, 2020
Some of the changes in NixOS#3788 to support non-systemd Nix installs
don't appear to be aware that the darwin installer exists, which
resulted in some skipped steps and inappropriate instructions.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/anyone-up-for-picking-at-some-nix-onboarding-improvements/13152/7

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-install-multi-user-nix-on-alpine/13909/1

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-to-install-multi-user-nix-on-alpine/13909/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants