SSH: don't force port 22 if none is given #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmertens
force-pushed
the
patch-1
branch
2 times, most recently
from
bacc4d4
to
e43d482
Compare
|
🎉 I can confirm this works. |
This way, the port specified in the SSH config can be used
|
I am a bit torn about this PR. I would consider making NixOps completely disregard For now I'll just merge this as-is. It does no harm and I'm not entirely convinced my reasoning is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the port specified in the SSH config can be used.
Note, this is completely untested, I just wanted to write this down to see what it would entail to fix #1053