New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't inherit Shape from NamedTuple #422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
- Coverage 81.88% 81.75% -0.13%
==========================================
Files 35 35
Lines 6094 6079 -15
Branches 1236 1238 +2
==========================================
- Hits 4990 4970 -20
- Misses 927 931 +4
- Partials 177 178 +1
Continue to review full report at Codecov.
|
whitequark
reviewed
Jul 6, 2020
Because I'm bad at python and didn't know iter() existed, and also I've
been writing Rust a lot and this is how you have to do it there.
…On Mon, Jul 6, 2020, 2:34 AM whitequark ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In nmigen/hdl/ast.py
<#422 (comment)>:
> @@ -55,8 +71,15 @@ class Shape(typing.NamedTuple):
signed : bool
If ``False``, the value is unsigned. If ``True``, the value is signed two's complement.
"""
- width: int = 1
- signed: bool = False
+ def __init__(self, width=1, signed=False):
+ if not isinstance(width, int) or width < 0:
+ raise TypeError("Width must be a non-negative integer, not {!r}"
+ .format(width))
+ self.width = width
+ self.signed = signed
+
+ def __iter__(self):
+ return ShapeIter(self.width, self.signed)
Why not return iter((self.width, self.signed))?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#422 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB35VVT5TIKM7BOMG36KKNTR2GLBDANCNFSM4ORHGAXQ>
.
|
whitequark
reviewed
Jul 7, 2020
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #421 .