Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.transformers: 3.0.1 -> 3.0.2 #92546

Merged
merged 2 commits into from Jul 11, 2020
Merged

python3Packages.transformers: 3.0.1 -> 3.0.2 #92546

merged 2 commits into from Jul 11, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 7, 2020

Motivation for this change

This is a bugfix release, also requires an update to tokenizers (which is included in this PR as a separate commit).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title prython3Packages.transformers: 3.0.1 -> 3.0.2 python3Packages.transformers: 3.0.1 -> 3.0.2 Jul 7, 2020
drewrisinger
drewrisinger suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending: unlock transformers->tokenizers dependency's version.

  • Diff LGTM
  • Commits LGTM
  • Builds clean via nix-review
  • self-tested.
https://github.com/NixOS/nixpkgs/pull/92546
4 packages built:
python37Packages.tokenizers python37Packages.transformers python38Packages.tokenizers python38Packages.transformers

@danieldk
Copy link
Contributor Author

@drewrisinger thanks for the review! (And all the other reviews for related packages.)

@danieldk danieldk merged commit 25bf552 into NixOS:master Jul 11, 2020
@danieldk danieldk deleted the transformers-0.8.1 branch July 11, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @jonringer @drewrisinger