beamerpresenter: init at 0.1.1 #92480
Merged
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
pacien
force-pushed
the
beamerpresenter-init
branch
from
2a65ee9 to
88cfad9
Compare
minijackson
approved these changes
Jul 6, 2020
ehmry
approved these changes
Jul 6, 2020
|
Cool, works for me. |
danieldk
suggested changes
Jul 7, 2020
Comment on lines
29
to
30
| install -m644 man/beamerpresenter.1 -Dt $out/share/man/man1/ | ||
| install -m644 man/beamerpresenter.conf.5 -Dt $out/share/man/man5/ |
There was a problem hiding this comment.
Use installManPage from installShellFiles.
There was a problem hiding this comment.
Replaced and amended.
| sha256 = "0j7wx3qqwhda33ig2464bi0j0a473y5p7ndy5f7f8x9cqdal1d01"; | ||
| }; | ||
|
|
||
| enableParallelBuilding = true; |
There was a problem hiding this comment.
Can be removed, parallel building is used by default for qmake.
Comment on lines
+35
to
+44
| desktopItem = makeDesktopItem { | ||
| name = pname; | ||
| desktopName = "BeamerPresenter"; | ||
| genericName = "Beamer presentation viewer"; | ||
| comment = "Simple dual screen pdf presentation software"; | ||
| icon = "beamerpresenter"; | ||
| categories = "Office;"; | ||
| exec = "beamerpresenter %F"; | ||
| mimeType = "application/pdf;application/x-pdf;"; | ||
| }; |
There was a problem hiding this comment.
Doesn't hurt to ask upstream to include a .desktop file, so that not every distribution has to define their own ;).
There was a problem hiding this comment.
Good idea; I opened a PR upstream: stiglers-eponym/BeamerPresenter#4
pacien
force-pushed
the
beamerpresenter-init
branch
from
88cfad9 to
219dafe
Compare
pacien
force-pushed
the
beamerpresenter-init
branch
from
219dafe to
e2b498f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This creates a package for BeamerPresenter, a PDF presentation viewer.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)CC: @minijackson