Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mixxx: 2.2.3 -> 2.2.4 #92482

Merged
merged 1 commit into from Jul 11, 2020
Merged

mixxx: 2.2.3 -> 2.2.4 #92482

merged 1 commit into from Jul 11, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jul 6, 2020

Motivation for this change

https://github.com/mixxxdj/mixxx/releases/tag/release-2.2.4

Update bot skipped it:

2020-07-05T15:14:47 mixxx 2.2.3 -> 2.2.4 https://repology.org/metapackage/mixxx/versions
2020-07-05T15:15:00 [version] generic version rewriter does not support multiple hashes

@matthiasbeyer can you perhaps check if streaming works for you with the systemwide libshout version? It might, as release notes contain this line:

Add workaround for broken libshout versions mixxxdj/mixxx#2040 mixxxdj/mixxx#2438

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
Copy link
Contributor

Unfortunately I cannot test.

@prusnak
Copy link
Member

prusnak commented Jul 7, 2020

According to comments in this commit mixxxdj/mixxx@9986605 the build system will use the internal copy if the system-wide libshout has higher version than 2.4.1. That means it does not make sense to try to use the system-wide 2.4.3 version, because it won't be used anyway.

Otherwise ACK.

@matthiasbeyer
Copy link
Contributor

Would it make sense to use our own libshout from a optimization-standpoint? Like,... less stuff compiled from the mixxx sources?

@prusnak
Copy link
Member

prusnak commented Jul 7, 2020 •
edited

Would it make sense to use our own libshout from a optimization-standpoint?

That's exactly what is happening. Mixxx uses nix-built libshout, but the older version of it - 2.4.1. If we used newer version, it would be ignored during the build.

@matthiasbeyer
Copy link
Contributor

So nothing to do here anymore, I guess...

@mmilata
Copy link
Member Author

mmilata commented Jul 7, 2020

Just checked that streaming works with the systemwide libshout as an input (which the mixxx build recognizes as incompatible and uses internal copy instead).

Advantage of this solution is that no action would be needed when libshout containing bugfix is released. Disadvantage is that it's less clear which version is used.

@prusnak prusnak mentioned this pull request Jul 10, 2020
Closed
10 tasks
@srhb srhb merged commit aca3de5 into NixOS:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@aszlig aszlig aszlig approved these changes

@matthiasbeyer matthiasbeyer matthiasbeyer approved these changes

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@bfortz bfortz Awaiting requested review from bfortz

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmilata @matthiasbeyer @prusnak @aszlig @srhb