python3Packages.tinycss2, python3Packages.cssselect2: cleanup tests #92496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
LGTM, thanks! |
|
@GrahamcOfBorg build python37Packages.cssselect2 python38Packages.cssselect2 python37Packages.tinycss2 python38Packages.tinycss2 |
drewrisinger
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
I have a slight preference to not worrying about code style (i.e. flake8, import sort) when packaging python packages, but not enough to add/maintain specific patches like this.
- Diff LGTM
- Commits LGTM
- Builds cleanly via
nix-review - Build has built-in tests, no extra tests run.
https://github.com/NixOS/nixpkgs/pull/92496
15 packages built:
python37Packages.cairosvg python37Packages.cssselect2 python37Packages.pygal python37Packages.qasm2image python37Packages.tinycss2 python37Packages.weasyprint python37Packages.xml2rfc python38Packages.cairosvg python38Packages.cssselect2 python38Packages.pygal python38Packages.qasm2image python38Packages.tinycss2 python38Packages.weasyprint xml2rfc sourcehut.metasrht
jonringer
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
https://github.com/NixOS/nixpkgs/pull/92496
2 packages marked as broken and skipped:
python37Packages.qasm2image python38Packages.qasm2image
13 packages built:
python37Packages.cairosvg python37Packages.cssselect2 python37Packages.pygal python37Packages.tinycss2 python37Packages.weasyprint python37Packages.xml2rfc python38Packages.cairosvg python38Packages.cssselect2 python38Packages.pygal python38Packages.tinycss2 python38Packages.weasyprint xml2rfc sourcehut.metasrht
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I noticed that #91967 and #91941 both fixed tinycss2's tests in different ways, but did not cause a conflict because they touched different parts of the file. I kept the upstream patch, as it seems like the better solution.
I also noticed that #91364 had, in my opinion, a better fix for cssselect2's tests, but appears to have been superseded by #91941, so I included that patch in this PR as well.
cc @colemickens @misuzu @drewrisinger
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)