New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemd: 245.6 -> 245.7 #94681
systemd: 245.6 -> 245.7 #94681
Conversation
pname = "systemd"; | ||
|
||
# When updating, use https://github.com/systemd/systemd-stable tree, not the development one! | ||
# Also fresh patches should be cherry-picked from that tree to our current one. | ||
src = fetchFromGitHub { | ||
owner = "systemd"; | ||
repo = "systemd-stable"; | ||
rev = "aa0cb635f1f6a4d9b50ed2cca7782f3f751be933"; | ||
sha256 = "191f0r1g946bsqxky00z78wygsxi9pld11y2q4374bshnpsff2ll"; | ||
rev = "1e6233ed07f7af08550fffa7a885cac1ac67a2c3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: this could be rev = "v${version}"
using the tags to make updates easier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This did beat us in the past - back in the time when we still kept our own nixos/systemd repo - see the (outdated) comment above.
I propose leaving it this way for this minor bump but I'll tackle it in #94354.
Apparently, this failure was on another checkout, not here. Sorry for the noise. |
@GrahamcOfBorg test systemd |
This should be ready to merge. |
We'd need to first merge the revert from master into staging, to properly rebase this. Let's just undo the revert once this has trickled through staging. |
80b4bfb
to
f31ef9e
Compare
@flokli do you know what checkout it was that broke it? It failed on the latest hydra run |
Not sure I understand the question. |
Ah my bad, sorry |
Motivation for this change
Updating systemd to the latest
systemd-stable
point release.Fixes #94678
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)