Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdm: 3.34.1 -> 3.36.3 #94656

Closed
wants to merge 1 commit into from
Closed

gdm: 3.34.1 -> 3.36.3 #94656

wants to merge 1 commit into from

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Aug 4, 2020

Motivation for this change

Version bump.
Changelog:

==============
Version 3.36.2
==============
- Fixes for when GDM isn't started on its configured initial VT
- Don't hardcode path to plymouth
- keyutils has a .pc file so use it
- Chrome remote desktop fix
- Always use separate session bus for greeter sessions
  This runs dbus-run-session, so the binary needs to be available
- Translation updates
==============
Version 3.36.3
==============
- User switching fix
- Translation updates
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC: @worldofpeace @jtojnar

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Aug 4, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 4, 2020

Do we actually have plymouth on PATH? If yes, we should stop passing it to substituteAll in the GDM expression.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 4, 2020

From the other changes, it might be nice to add keyutils dependency if it enables to reuse the LUKS password. @hedning might know better if the VT changes affect us.

@hedning
Copy link
Contributor

hedning commented Aug 4, 2020

Do we actually have plymouth on PATH?

Yeah, it should be available when boot.plymouth.enable is true:

nixpkgs/nixos/modules/system/boot/plymouth.nix

Line 87 in 3bc1b7b

environment.systemPackages = [ plymouth ];

So sort of an accident, but means we don't need to keep plymouth in the closure I guess.

might know better if the VT changes affect us.

Looks like they simply make sure user sessions aren't launched on GDM's designated VT (7 in our case). Don't think that should affect us at all tbh as it's already fairly unlikely for GDM to launch a session on VT7 in the first place.

@worldofpeace
Copy link
Contributor

Just want to mention we had an issue in lightdm where plymouth had to be hardcoded https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/display-managers/lightdm/default.nix#L95. Not sure if that will spark the same issue here though, but I think it's possible to be likely.

@worldofpeace
Copy link
Contributor

I just tried this on my machine and it locks up with plymouth. So I think it needs to be hardcoded.

@dasj19 dasj19 force-pushed the gdm-updates branch 2 times, most recently from d5632c7 to 2c9d28a Compare August 9, 2020 11:19
@dasj19
Copy link
Contributor Author

dasj19 commented Aug 9, 2020

@worldofpeace I have hardcoded the path to plymouth binary within the fix-paths.patch
@jtojnar I am adding keyutils to the dependencies right now.

@jtojnar
Copy link
Contributor

jtojnar commented Aug 9, 2020

@GrahamcOfBorg test gnome3 gnome3-xorg

@doronbehar
Copy link
Contributor

gdm is updated now.

@doronbehar doronbehar closed this Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasj19 @jtojnar @hedning @worldofpeace @doronbehar