Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lorri: 1.1.1 -> 1.2.0 #94667

Merged
merged 1 commit into from Aug 4, 2020
Merged

lorri: 1.1.1 -> 1.2.0 #94667

merged 1 commit into from Aug 4, 2020

Conversation

Profpatsch
Copy link
Member

@Profpatsch Profpatsch commented Aug 4, 2020 •
edited

Motivation for this change

Small-ish update, exposing the new varlink interface. Also slight refactor of the nix expression.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @nyarly @curiousleo

@ofborg ofborg bot requested a review from grahamc August 4, 2020 15:57
aszlig
aszlig requested changes Aug 4, 2020
View reviewed changes
Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please either remove the mentioned comment or split it up into another commit and explain what it's actually for.

Awful in-joke Please use git-badc0de next time.

@aszlig
Copy link
Member

aszlig commented Aug 4, 2020

Note that I haven't tested this, the approval is only based on reviewing the diff.

@Profpatsch Profpatsch merged commit c253216 into NixOS:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig aszlig approved these changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Profpatsch @aszlig