pythonPackages.iterfzf: init at 0.5.0.20.0 #94661

swflint · 2020-08-04T14:11:29Z

Motivation for this change

I'm slowly working on packaging the Remt tool for Remarkable Tablets. This package is required, and not packaged in NixOS.

Things done

jonringer · 2020-08-04T19:54:06Z

pkgs/development/python-modules/iterfzf/default.nix

+  propagatedBuildInputs = [
+    fzf
+  ];


this will propagate the fzf command to the environment which should be avoided. Patching should be used instead

Suggested change

propagatedBuildInputs = [

fzf

];

prePatch = ''

substituteInPlace iterfzf/__init__.py \

--replace "EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else 'fzf'" \

"EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else '${fzf}/bin/fzf'

'';

jonringer · 2020-08-04T19:54:34Z

pkgs/top-level/python-packages.nix

@@ -7310,6 +7310,8 @@ in {

  inflect = callPackage ../development/python-modules/inflect { };

+  iterfzf = callPackage ../development/python-modules/iterfzf { };


incase a fzf package gets added to python scope

Suggested change

iterfzf = callPackage ../development/python-modules/iterfzf { };

iterfzf = callPackage ../development/python-modules/iterfzf {

inherit (pkgs) fzf;

};

jonringer

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

pythonPackages.iterfzf: init at 0.5.0.20.0"

please squash the fixup commits

risicle · 2020-08-15T12:57:36Z

Build on macos 10.14 fails:

...
  Using pythonImportsCheckPhase
  Sourcing python-namespaces-hook
  Sourcing setuptools-check-hook
  Using setuptoolsCheckPhase
  unpacking sources
  unpacking source archive /nix/store/mjlkkiqkh4nq54gq2ls61gbmp7f45zfv-source
  source root is source
  setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/tox.ini
  patching sources
  /nix/store/ddm1y988d42mxmz62fzg8xz3ladxz8vq-stdenv-darwin/setup: eval: line 91: unexpected EOF while looking for matching `"'

edit: and it's quite right - there's a missing " in the prePatch, same failure on linux.

swflint · 2020-08-27T18:30:54Z

Go figure. Something easy enough to fix at least.

First couple of weeks of this semester have been interesting.

jonringer · 2020-08-27T19:49:21Z

pkgs/development/python-modules/iterfzf/default.nix

+  '';
+


There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.

---------------------------------------------------------------------- Ran 0 tests in 0.000s

It looks like the sources have no tests. So, I'd say pythonImportsCheck is the best we can do right now.

urbas · 2021-01-16T09:20:22Z

pkgs/development/python-modules/iterfzf/default.nix

+  '';
+


It looks like the sources have no tests. So, I'd say pythonImportsCheck is the best we can do right now.

urbas · 2021-01-16T09:23:25Z

pkgs/top-level/python-packages.nix

+  iterfzf = callPackage ../development/python-modules/iterfzf {
+    inherit (pkgs) fzf;
+  };


You can omit the inherit (it will be automatically passed):

iterfzf = callPackage ../development/python-modules/iterfzf { };

urbas · 2021-01-16T09:24:41Z

pkgs/development/python-modules/iterfzf/default.nix

+  src = fetchFromGitHub {
+    owner = "dahlia";
+    repo = pname;
+    rev = version;
+    sha256 = "0nrfq1zj4pwlgyd8ra5wl7skdbzvnxdh7wwhyh83y7yax8sp1xvj";
+  };


I'd recommend using the fetchPypi function instead (this way you'll benefit from automatic updates):

src = fetchPypi { inherit pname version; sha256 = "0by5pk7w1j2xzhj4l0nw09sz9025pdskbf1b7k87kfkwgbc08vrb"; };

urbas · 2021-01-16T09:44:59Z

I tried this change out in a pure nix-shell and it seems to be working:

The nix-shell expression used:

nix-shell -I nixpkgs=$(pwd) -p python3Packages.ipython python3Packages.iterfzf --pure

urbas · 2021-01-21T07:24:28Z

Looks like there is a merge conflict. Could you rebase?

swflint · 2021-01-29T02:13:01Z

Is there anything else I need to do?

SuperSandro2000 · 2021-03-21T03:24:18Z

pkgs/development/python-modules/iterfzf/default.nix

+  };
+
+}


Suggested change

};

}

};

}

SuperSandro2000 · 2021-03-21T03:24:33Z

pkgs/development/python-modules/iterfzf/default.nix

+    substituteInPlace iterfzf/__init__.py \
+                      --replace "EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else 'fzf'" \
+                      "EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else '${fzf}/bin/fzf'"


Suggested change

substituteInPlace iterfzf/__init__.py \

--replace "EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else 'fzf'" \

"EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else '${fzf}/bin/fzf'"

substituteInPlace iterfzf/__init__.py \

--replace "EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else 'fzf'" \

"EXECUTABLE_NAME = 'fzf.exe' if sys.platform == 'win32' else '${fzf}/bin/fzf'"

stale · 2021-09-19T01:23:39Z

I marked this as stale due to inactivity. → More info

SuperSandro2000

closing due to inactivity. Feel free to re-open.

SuperSandro2000 · 2022-11-08T00:04:31Z

pkgs/development/python-modules/iterfzf/default.nix

+    sha256 = "0by5pk7w1j2xzhj4l0nw09sz9025pdskbf1b7k87kfkwgbc08vrb";
+  };
+
+  prePatch = ''


Suggested change

prePatch = ''

postPatch = ''

swflint requested review from FRidh and jonringer as code owners August 4, 2020 14:11

ofborg bot added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer labels Aug 4, 2020

jonringer reviewed Aug 4, 2020

View reviewed changes

swflint force-pushed the add-iter-fzf branch from 18b0ec8 to 1f3d204 Compare August 4, 2020 22:31

swflint force-pushed the add-iter-fzf branch from 1f3d204 to f21950e Compare August 27, 2020 18:30

jonringer reviewed Aug 27, 2020

View reviewed changes

swflint force-pushed the add-iter-fzf branch from f21950e to e2cbe79 Compare August 28, 2020 13:35

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

urbas suggested changes Jan 16, 2021

View reviewed changes

swflint force-pushed the add-iter-fzf branch from e2cbe79 to bd0c1c8 Compare January 19, 2021 14:56

swflint force-pushed the add-iter-fzf branch from bd0c1c8 to 15de4dc Compare January 21, 2021 15:06

ofborg bot removed the 2.status: merge conflict label Jan 21, 2021

pythonPackages.iterfzf: init at 0.5.0.20.0

39fa7a0

swflint force-pushed the add-iter-fzf branch from 15de4dc to 39fa7a0 Compare January 21, 2021 15:51

urbas approved these changes Jan 21, 2021

View reviewed changes

urbas requested a review from jonringer January 31, 2021 17:56

SuperSandro2000 requested changes Mar 21, 2021

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2021

SuperSandro2000 requested changes Nov 8, 2022

View reviewed changes

SuperSandro2000 closed this Nov 8, 2022

stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.iterfzf: init at 0.5.0.20.0 #94661

pythonPackages.iterfzf: init at 0.5.0.20.0 #94661

swflint commented Aug 4, 2020

jonringer Aug 4, 2020 •

edited

jonringer Aug 4, 2020

jonringer left a comment

risicle commented Aug 15, 2020 •

edited

swflint commented Aug 27, 2020

jonringer Aug 27, 2020

urbas Jan 16, 2021

urbas Jan 16, 2021

urbas Jan 16, 2021

urbas Jan 16, 2021

urbas commented Jan 16, 2021 •

edited

urbas commented Jan 21, 2021

swflint commented Jan 29, 2021

SuperSandro2000 Mar 21, 2021

SuperSandro2000 Mar 21, 2021

stale bot commented Sep 19, 2021

SuperSandro2000 left a comment

SuperSandro2000 Nov 8, 2022

		@@ -7310,6 +7310,8 @@ in {

		inflect = callPackage ../development/python-modules/inflect { };

		iterfzf = callPackage ../development/python-modules/iterfzf { };

-  };
-}
+  };
+}

pythonPackages.iterfzf: init at 0.5.0.20.0 #94661

pythonPackages.iterfzf: init at 0.5.0.20.0 #94661

Conversation

swflint commented Aug 4, 2020

Motivation for this change

Things done

jonringer Aug 4, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonringer left a comment

Choose a reason for hiding this comment

risicle commented Aug 15, 2020 • edited

swflint commented Aug 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

urbas commented Jan 16, 2021 • edited

urbas commented Jan 21, 2021

swflint commented Jan 29, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Sep 19, 2021

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonringer Aug 4, 2020 •

edited

risicle commented Aug 15, 2020 •

edited

urbas commented Jan 16, 2021 •

edited