beets: apply patch to fix incompatibilites with python 3.8 #94692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build beets |
aszlig
approved these changes
Aug 6, 2020
pkgs/tools/audio/beets/default.nix
Outdated
| # Fixes 548 tests due to breaking changes to the ast module | ||
| # https://github.com/beetbox/beets/pull/3621 | ||
| # Can be dropped after 1.4.9 | ||
| ./compatibility-with-breaking-changes-to-the-ast-modul.patch |
There was a problem hiding this comment.
Suggested change
| ./compatibility-with-breaking-changes-to-the-ast-modul.patch | |
| ./compatibility-with-breaking-changes-to-the-ast-module.patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
548 tests in beets were failing due to a breaking change to the ast module that was backported to python 3.8.
beetbox/beets#3621
python/cpython#20649
The upstream patch did not apply cleanly onto 1.4.9, so here we are.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)