Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: add Jitsi maintainers #94677

Merged
merged 1 commit into from Aug 4, 2020
Merged

treewide: add Jitsi maintainers #94677

merged 1 commit into from Aug 4, 2020

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Aug 4, 2020

  • makes jitsi maintainer team

@dpausp I don't see you in the maintainer list, so please add yourself after this is merged.

Motivation for this change

Many Jitsi modules and programs need maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @petabyteboy @Ma27

@ryantm ryantm requested review from prusnak and mmilata August 4, 2020 20:05
@ghost
Copy link

ghost commented Aug 4, 2020

Feel free to add me as well.

@ryantm
treewide: add Jitsi maintainers
c4814c0 
* makes jitsi maintainer team
@ryantm
Copy link
Member Author

ryantm commented Aug 4, 2020

Feel free to add me as well.

Done!

@Ma27 Ma27 merged commit 88681e0 into NixOS:master Aug 4, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 4, 2020

Thanks for taking care of Jitsi! :)

@ryantm ryantm deleted the jitsi branch August 4, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryantm @Ma27 @prusnak @mmilata