Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/agetty: allow overriding the login program #94698

Merged
merged 1 commit into from Jul 19, 2021
Merged

nixos/agetty: allow overriding the login program #94698

merged 1 commit into from Jul 19, 2021

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Aug 5, 2020 •
edited

Motivation for this change

NixOS currently hardcodes the use of shadow's /bin/login on console and serial terminals. This allows using an alternate implementation, e.g. https://github.com/google/glome (my current use case).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/288

jonringer
jonringer approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

cc @infinisil

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@delroth delroth changed the title nixos/agetty: allow overriding the login program and options nixos/agetty: allow overriding the login program Jul 19, 2021
@delroth
Copy link
Contributor Author

delroth commented Jul 19, 2021

@jonringer in the absence of comments for almost a year, since you reviewed this, mind merging this PR?

Note that since I wrote this PR "loginOptions" got independently added to the agetty module, so this PR now is only the very simple loginProgram addition.

@jonringer jonringer merged commit cbe99c7 into NixOS:master Jul 19, 2021
@jonringer
Copy link
Contributor

yea, looks pretty non-controversial :)

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@delroth @nixos-discourse @jonringer @SuperSandro2000