Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dask-gateway: init at 0.8.0 #94693

Merged
merged 2 commits into from Aug 8, 2020
Merged

pythonPackages.dask-gateway: init at 0.8.0 #94693

merged 2 commits into from Aug 8, 2020

Conversation

costrouc
Copy link
Member

@costrouc costrouc commented Aug 5, 2020

Motivation for this change

Looking at creating dask-gateway nixos service for hpc computations. Need package to exist first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc changed the title Python dask gateway init pythonPackages.dask-gateway: init at 0.8.0 Aug 5, 2020
@costrouc
Copy link
Member Author

costrouc commented Aug 5, 2020

Result of nixpkgs-review pr 94693 1

4 packages built:
- python37Packages.dask-gateway
- python37Packages.dask-gateway-server
- python38Packages.dask-gateway
- python38Packages.dask-gateway-server

@costrouc
Copy link
Member Author

costrouc commented Aug 5, 2020

@GrahamcOfBorg build python3Packages.dask-gateway python3Packages.dask-gateway-server

jonringer
jonringer reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the server is just meant to be an application (E.g: dask-server ... ) I would prefer for it to be packaged as an application. Otherwise the use of go needs to be patched into the call sites if it's a package.

pkgs/development/python-modules/dask-gateway/default.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
FRidh
FRidh reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case they're needed to be updated in lockstep, consider adding the other package to passthru.tests. At least ofborg will test that then.

@costrouc
Copy link
Member Author

costrouc commented Aug 5, 2020

@jonringer needs to be a python package due to how it is used. Often times the dask-gateway-server is subclassed to add additional features to the server. I wish that they hadn't decided to build a go proxy server that is self contained in the package (the proxy server will not be extended). Especially since there are existing tools that fit their use case e.g. traefik.

@FRidh both of these packages come from the same git repo https://github.com/dask/dask-gateway. So me saying that they need to be updated together is because they are released together. Should I switch to using the git repo and build from that? Should I set dask-gateway.src = dask-gateway-server.src; dask-gateway.version = dask-gateway-server.version; for example. I'm thinking this would be more robust.

@costrouc
Copy link
Member Author

costrouc commented Aug 5, 2020

@GrahamcOfBorg build python3Packages.dask-gateway python3Packages.dask-gateway-server

@costrouc
Copy link
Member Author

costrouc commented Aug 7, 2020

Result of nixpkgs-review pr 94693 1

4 packages built:
- python37Packages.dask-gateway
- python37Packages.dask-gateway-server
- python38Packages.dask-gateway
- python38Packages.dask-gateway-server

@costrouc
Copy link
Member Author

costrouc commented Aug 7, 2020

@GrahamcOfBorg build python3Packages.dask-gateway python3Packages.dask-gateway-server

@jonringer
Copy link
Contributor

do you mind reviewing #94894

jonringer
jonringer approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94693 1

4 packages built: - python37Packages.dask-gateway - python37Packages.dask-gateway-server - python38Packages.dask-gateway - python38Packages.dask-gateway-server

@jonringer jonringer merged commit 7b04c0f into NixOS:master Aug 8, 2020
@costrouc costrouc deleted the python-dask-gateway-init branch August 8, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@costrouc @jonringer @FRidh