Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtg: init at 0.4.0 (Getting Things GNOME) #94686

Merged
merged 2 commits into from Aug 5, 2020
Merged

gtg: init at 0.4.0 (Getting Things GNOME) #94686

merged 2 commits into from Aug 5, 2020

Conversation

oyren
Copy link
Contributor

@oyren oyren commented Aug 4, 2020

Motivation for this change

Adding Getting Things GNOME as requested here #93370.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@oyren oyren requested a review from jtojnar August 4, 2020 22:26
@oyren oyren requested a review from jonringer August 4, 2020 23:52
jonringer
jonringer approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94686 1

1 package failed to build:
- python27Packages.liblarch
3 packages built:
- gtg
- python37Packages.liblarch
- python38Packages.liblarch

@jonringer jonringer merged commit 2d6c269 into NixOS:master Aug 5, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/getting-things-gnome-modulenotfounderror-no-module-named-gi/8439/4

@oyren
Copy link
Contributor Author

oyren commented Aug 5, 2020

#94710

@oyren oyren deleted the add-gtg branch August 5, 2020 18:06
This was referenced Aug 10, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oyren @nixos-discourse @jtojnar @jonringer