Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borgbackup: Allow backup of data streams #94685

Closed
wants to merge 4 commits into from
Closed

borgbackup: Allow backup of data streams #94685

wants to merge 4 commits into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Aug 4, 2020 •
edited

Motivation for this change

Borgbackup is able to backup data from stdin. I had to backup an unmounted ZFS dataset, which is only possible by having borgbackup read the data from a pipe.
Kind of quickly hacked together, but at least my first backup is running right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented Aug 4, 2020

@GrahamcOfBorg test borgbackup

@tokudan
Copy link
Contributor Author

tokudan commented Aug 10, 2020

@GrahamcOfBorg test borgbackup

@tokudan tokudan requested a review from xeji August 16, 2020 08:23
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/269

taku0
taku0 approved these changes Feb 13, 2021
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM.

@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2021
@pennae
Copy link
Contributor

pennae commented Oct 3, 2021

would be interested in having this. what can we do to help get this merged?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2021
@pennae
Copy link
Contributor

pennae commented Oct 3, 2021

on closer inspection and testing there's a lot that should be changed here:

  • the entire backup job should fail if the backup command fails
  • backupCommand should be path, not str
  • ideally paths = [ "-" ] would be implicit when setting backupCommand, and setting both would be an error

@pennae pennae mentioned this pull request Oct 11, 2021
Merged
12 tasks
@pennae pennae closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@xeji xeji Awaiting requested review from xeji

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tokudan @nixos-discourse @pennae @taku0 @xeji