tanka: init at v0.11.1 #94659
Merged
tanka: init at v0.11.1 #94659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timstott
reviewed
Aug 4, 2020
|
Yessir ! I never saw that. But, I will in the future !
Le mar. 4 août 2020 18:21, Timothy Stott <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In pkgs/applications/networking/cluster/tanka/default.nix
<#94659 (comment)>:
> @@ -0,0 +1,23 @@
+{ buildGoModule, fetchFromGitHub, lib }:
+
+buildGoModule rec {
+ pname = "tanka";
+ version = "0.11.1";
+
+ src = fetchFromGitHub {
+ owner = "grafana";
+ repo = pname;
+ rev = "v${version}";
+ sha256 = "0hp10qgalglsdhh6z6v4azh2hsr89mdrv1g5lssfl5jyink409yd";
+ };
+
+ vendorSha256 = "15x8fqz2d2793ivgxpd9jyr34njzi1xpyxdlfyj1b01n2vr3xg4m";
+
🙋 Could we please set the package version main.Version=${version} via
buildFlagsArray.
As an example the gopass package:
https://github.com/NixOS/nixpkgs/blob/e3cba5aad991a0f355545fc0b069cbf987b577d0/pkgs/tools/security/gopass/default.nix#L25
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#94659 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHO2FHDQBZE5LXUE3PWBB3R7CCU7ANCNFSM4PUMTNOQ>
.
|
|
I will change it as soon I join my computer I mean
Le mar. 4 août 2020 18:43, Michael Faille <michael.faille@gmail.com> a
écrit :
… Yessir ! I never saw that. But, I will in the future !
Le mar. 4 août 2020 18:21, Timothy Stott ***@***.***> a
écrit :
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In pkgs/applications/networking/cluster/tanka/default.nix
> <#94659 (comment)>:
>
> > @@ -0,0 +1,23 @@
>
> +{ buildGoModule, fetchFromGitHub, lib }:
>
> +
>
> +buildGoModule rec {
>
> + pname = "tanka";
>
> + version = "0.11.1";
>
> +
>
> + src = fetchFromGitHub {
>
> + owner = "grafana";
>
> + repo = pname;
>
> + rev = "v${version}";
>
> + sha256 = "0hp10qgalglsdhh6z6v4azh2hsr89mdrv1g5lssfl5jyink409yd";
>
> + };
>
> +
>
> + vendorSha256 = "15x8fqz2d2793ivgxpd9jyr34njzi1xpyxdlfyj1b01n2vr3xg4m";
>
> +
>
>
> 🙋 Could we please set the package version main.Version=${version} via
> buildFlagsArray.
>
> As an example the gopass package:
>
> https://github.com/NixOS/nixpkgs/blob/e3cba5aad991a0f355545fc0b069cbf987b577d0/pkgs/tools/security/gopass/default.nix#L25
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#94659 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHO2FHDQBZE5LXUE3PWBB3R7CCU7ANCNFSM4PUMTNOQ>
> .
>
|
mikefaille
force-pushed
the
tanka
branch
3 times, most recently
from
f5696ff
to
2b78b5c
Compare
|
Result of 1 package built:- tanka |
timstott
approved these changes
Aug 6, 2020
danieldk
suggested changes
Aug 8, 2020
There was a problem hiding this comment.
I think this can be enabled for all Unix platforms.
Also, it seems that the tk command supports bash completions. Would be nice to add them as well. Something like the following in postInstall should work (untested):
echo "complete -C $out/bin/tk tk" > tk.bash
installShellCompletion tk.bash
(And add installShellFiles to nativeBuildInputs).
| homepage = "https://github.com/grafana/tanka/"; | ||
| license = licenses.asl20; | ||
| maintainers = with maintainers; [ mikefaille ]; | ||
| platforms = platforms.linux ++ platforms.darwin; |
There was a problem hiding this comment.
Any reason to suspect that this doesn't work on other Unixes?
Suggested change
| platforms = platforms.linux ++ platforms.darwin; | |
| platforms = platforms.unix; |
There was a problem hiding this comment.
BSD systems works for Nix ?
There was a problem hiding this comment.
Some people are working on it. Once there is more mature support, it would be nice to have these derivations (that probably work just fine) work immediately.
There was a problem hiding this comment.
It would be a pleasure to support BSD :D
|
@danieldk Yes, I would try, It seems it injects |
|
Oh, I just seen the comment above. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tanka is a tool built by Grafana and Redhat to facilitate Kubernetes assets on jsonnet format.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)