Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jruby: 9.2.12.0 → 9.2.13.0 #94672

Merged
merged 2 commits into from Aug 4, 2020
Merged

jruby: 9.2.12.0 → 9.2.13.0 #94672

merged 2 commits into from Aug 4, 2020

Conversation

fzakaria
Copy link
Contributor

@fzakaria fzakaria commented Aug 4, 2020

Motivation for this change

Bump JRuby to latest release
https://www.jruby.org/2020/08/03/jruby-9-2-13-0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I built the latest JRuby package and ran the following

> nix-build -E 'with import <nixpkgs> {}; callPackage ./pkgs/development/interpreters/jruby {}' --pure
> cd ./result/bin

> PATH=$(pwd):$PATH ruby -e 'puts RUBY_VERSION'
2.5.7

> PATH=$(pwd):$PATH gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 3.0.6
  - RUBY VERSION: 2.5.7 (2020-08-03 patchlevel 0) [java]
  - INSTALLATION DIRECTORY: /nix/store/g4pfrjl276hc1rxccdxccrpk2nw1qk8j-jruby-9.2.13.0/lib/ruby/gems/shared
  - USER INSTALLATION DIRECTORY: /home/fmzakari/.gem/jruby/2.5.0
  - RUBY EXECUTABLE: /nix/store/g4pfrjl276hc1rxccdxccrpk2nw1qk8j-jruby-9.2.13.0/bin/jruby
  - GIT EXECUTABLE: /home/fmzakari/.nix-profile/bin/git
  - EXECUTABLE DIRECTORY: /nix/store/g4pfrjl276hc1rxccdxccrpk2nw1qk8j-jruby-9.2.13.0/bin
  - SPEC CACHE DIRECTORY: /home/fmzakari/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: /nix/store/g4pfrjl276hc1rxccdxccrpk2nw1qk8j-jruby-9.2.13.0/etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - universal-java-1.8
  - GEM PATHS:
     - /nix/store/g4pfrjl276hc1rxccdxccrpk2nw1qk8j-jruby-9.2.13.0/lib/ruby/gems/shared
     - /home/fmzakari/.gem/jruby/2.5.0

@fzakaria
Copy link
Contributor Author

fzakaria commented Aug 4, 2020

Trying to beat @ryantm update bot :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/245

@fzakaria fzakaria force-pushed the faridzakaria/jruby-9.2.13.0 branch from f25b9f3 to 0a68d96 Compare August 4, 2020 19:02
jonringer
jonringer approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shows usage

https://github.com/NixOS/nixpkgs/pull/94672
1 package built:
jruby

@jonringer jonringer merged commit ea7e87a into NixOS:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzakaria @nixos-discourse @jonringer