Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnunet{,-gtk}: bump to 0.13.1 #94689

Merged
merged 3 commits into from Aug 5, 2020
Merged

gnunet{,-gtk}: bump to 0.13.1 #94689

merged 3 commits into from Aug 5, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 4, 2020 •
edited

Motivation for this change

follow up to: #77828

the gnunet and gnunet-gtk project seem to be developed in tandem, seems to make sense to have them under the same directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

cc @pstn @vrthra

@pstn
Copy link
Contributor

pstn commented Aug 5, 2020

Changes look good, weird localization behaviour of gnunet-fs-gtk seems to be gone, too.

Anybody against moving me as maintainer to default.nix and also inherit over to gtk.nix? Doesn't seem to make sense to just maintain one of the two when they even share the version number.

@jonringer
Copy link
Contributor Author

@pstn please take another look

@pstn
Copy link
Contributor

pstn commented Aug 5, 2020

I like the changes and learned about mirror:// in nixpkgs. Good to know. Executables still seem fine, too.

@xeji xeji merged commit 36f872a into NixOS:master Aug 5, 2020
@jonringer jonringer deleted the bump-gnunet branch August 5, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @pstn @xeji