Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postman: fix and add libuuid as dependency #91933

Merged
merged 1 commit into from Jul 7, 2020
Merged

Postman: fix and add libuuid as dependency #91933

merged 1 commit into from Jul 7, 2020

Conversation

ngerstle-cognite
Copy link
Contributor

@ngerstle-cognite ngerstle-cognite commented Jul 1, 2020 •
edited

Motivation for this change

Postman is failing on NixOS:
/home/user/.nix-profile/bin/postman: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from evanjs July 1, 2020 23:16
evanjs
evanjs suggested changes Jul 4, 2020
View reviewed changes
Copy link
Member

@evanjs evanjs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not realize just how limited the suggestion interface is (I can't suggest edits on hunks not touched by the PR?)
Or maybe I'm just using it wrong :D

Anyway! Adding at-spi2-core (in addition to libuuid) to the arguments and buildInputs seems to get things running again.

Thank you!

pkgs/development/web/postman/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from evanjs July 6, 2020 12:31
@DamienCassou
Copy link
Contributor

Result of nixpkgs-review pr 91933 1

1 package built:
- postman

@DamienCassou DamienCassou merged commit 8caac93 into NixOS:master Jul 7, 2020
@DamienCassou
Copy link
Contributor

Thank you.

@ngerstle-cognite
Copy link
Contributor Author

Thanks for merging!

@ngerstle-cognite ngerstle-cognite deleted the patch-1 branch July 7, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamienCassou DamienCassou DamienCassou left review comments

@evanjs evanjs Awaiting requested review from evanjs

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngerstle-cognite @DamienCassou @evanjs