Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeal: 0.6.1 -> 0.6.999 #91913

Merged
merged 1 commit into from Jul 2, 2020
Merged

zeal: 0.6.1 -> 0.6.999 #91913

merged 1 commit into from Jul 2, 2020

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Upstream is getting very close to releasing 0.7.0 but 0.6.1 depends on
qtwebkit which is deprecated and no longer built by hydra, so better
jump to the newer version that works with qtwebengine.

This works just as well as 0.6.1 and will be updated when 0.7.0 proper
is released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member Author

@worldofpeace and @jonringer - any comments as master reviewers?

@teto
Copy link
Member

teto commented Jul 1, 2020

oh sweet, I just noticed I was buiilding qtwebkit because of zeal this morning.

@peterhoeg
Copy link
Member Author

I just noticed I was buiilding qtwebkit because of zeal this morning.

That's how I noticed as well...

@peterhoeg peterhoeg merged commit 2676464 into NixOS:master Jul 2, 2020
@peterhoeg peterhoeg deleted the u/zeal branch July 2, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants