Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve jupyter service #91895

Merged
merged 2 commits into from Jul 11, 2020
Merged

Improve jupyter service #91895

merged 2 commits into from Jul 11, 2020

Conversation

kristoff3r
Copy link
Contributor

Motivation for this change

I want to use the jupyter service with the jupyterWith package and a Rust kernel, so I added the necessary options to make that work. I also fixed a bug in the evcxr package. I have tested both of these changes on my machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kristoff3r kristoff3r changed the title services.jupyter: add options Improve jupyter service Jun 30, 2020
@ofborg ofborg bot requested review from protoben and Ma27 June 30, 2020 21:51
@kristoff3r kristoff3r mentioned this pull request Jul 1, 2020
Merged
@kristoff3r kristoff3r requested a review from FRidh July 1, 2020 13:55
@kristoff3r
Copy link
Contributor Author

kristoff3r commented Jul 1, 2020 •
edited

I changed useJupyterLabs to a command option. I can't retest it myself right now because I am at work, but the change is hopefully small enough for it to still work.

Thanks for the quick review!

@FRidh FRidh requested a review from aborsu July 1, 2020 14:03
@kristoff3r
nixos/jupyter: add package and command options
80a7a42
@kristoff3r
evcxr: wrap evcxr_jupyter binary
a8b68fc 
evcxr_jupyter needs the same wrapper as the main binary to work.
@kristoff3r
Copy link
Contributor Author

I fixed accidentally using types.string instead of types.str, and me plus another person have been using this without problems for a week now. The default behavior is also exactly the same as before, so I think this can be safely merged.

@Ma27 Ma27 merged commit 3d9c143 into NixOS:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@protoben protoben Awaiting requested review from protoben

@FRidh FRidh Awaiting requested review from FRidh

@aborsu aborsu Awaiting requested review from aborsu

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kristoff3r @FRidh @Ma27