New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pidgin: now builds and runs on osx #91882
Conversation
We can now build and run pidgin on OSX. Pidgin requires an X11 server to run. * Build: Differences Linux and OSX now parameterized * Darwin: build against gtk2-x11 instead of gtk * Darwin: disable gtkspell2 (spellcheck) * Darwin: disable farstream (voice and video) Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
pkgs/applications/networking/instant-messengers/pidgin/default.nix
Outdated
Show resolved
Hide resolved
Signed-off-by: Frederick F. Kautz IV <fkautz@alumni.cmu.edu>
Not quite sure if I need to disable the sandbox?
|
@Mic92 was that posted to the correct PR? This code shouldn't affect anything in that library. |
@vcunat I've ran |
Well startup-notifications is one of pidgin's dependencies. I built with nix-review with also does a merge into current master before running the build. |
@Mic92 what command did you use to reproduce this? I'm very new here so still trying to navigate the tooling. :) I was just using And would this be the appropriate PR to fix that problem or should I open a new PR? |
You can reproduce it by @GrahamcOfBorg build pidgin |
Signed-off-by: Frederick F. Kautz IV fkautz@alumni.cmu.edu
A quick note: this is my first patch in nixpkgs. I don't know if I have followed best practices. E.g. I read sandboxing is enabled by default but I don't know how to confirm it.
Also, this package does require an X11 server to run. Nix does provide access to the xquartz installer, but it is possible to run pidgin with an already running X11 server.
Motivation for this change
Before: No Pidgin on OSX
After: Pidgin on OSX
Things done
Changed build to support unix.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)