Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc810x: remove obsolete overrides (3/x) #91950

Merged
merged 1 commit into from Jul 3, 2020
Merged

ghc810x: remove obsolete overrides (3/x) #91950

merged 1 commit into from Jul 3, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jul 1, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

regex-pcre-builtin: -doJailbreak
regex-posix: -doJailbreak
regex-tdfa: -doJailbreak
split: -doJailbreak
tar: -doJailbreak

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 1, 2020

@GrahamcOfBorg build haskell.packages.ghc8101.regex-pcre-builtin
@GrahamcOfBorg build haskell.packages.ghc8101.regex-posix
@GrahamcOfBorg build haskell.packages.ghc8101.regex-tdfa
@GrahamcOfBorg build haskell.packages.ghc8101.split
@GrahamcOfBorg build haskell.packages.ghc8101.tar

@cdepillabout
Copy link
Member

Ah sorry, looks like this PR conflicts with a previous one as well. If you fix this up I'd be happy to merge it in.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 2, 2020

Will do, just waiting on #91945 so we don't run into another one.

@svmhdvn
ghc810x: remove obsolete overrides (3/x)
72f9a48 
regex-pcre-builtin: -doJailbreak
regex-posix: -doJailbreak
regex-tdfa: -doJailbreak
split: -doJailbreak
tar: -doJailbreak
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 3, 2020

@GrahamcOfBorg build haskell.packages.ghc8101.regex-pcre-builtin
@GrahamcOfBorg build haskell.packages.ghc8101.regex-posix
@GrahamcOfBorg build haskell.packages.ghc8101.regex-tdfa
@GrahamcOfBorg build haskell.packages.ghc8101.split
@GrahamcOfBorg build haskell.packages.ghc8101.tar

@cdepillabout
Copy link
Member

Looks good, thanks for updating this one as well.

@cdepillabout cdepillabout merged commit 24d29a5 into NixOS:haskell-updates Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@svmhdvn @cdepillabout