Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sd-image: Add option to control sd image expansion on boot. #91955

Merged
merged 1 commit into from May 1, 2021
Merged

sd-image: Add option to control sd image expansion on boot. #91955

merged 1 commit into from May 1, 2021

Conversation

c00w
Copy link
Contributor

@c00w c00w commented Jul 1, 2020 •
edited

This is super useful to allow the normal sd-image code to be used by
someone who wants to setup multiple partitions with a sd-image.

Currently I'm manually copying the sd-image file and modifying it
instead.

Tested by running

nix-build nixos -I nixos-config=nixos/modules/installer/cd-dvd/sd-image-aarch64.nix --argstr system
aarch64-linux -A config.system.build.sdImage

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c00w
Copy link
Contributor Author

c00w commented Aug 2, 2020

@misuzu - done.

@samueldr - any chance you can review?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 29, 2020 •
edited

@ofborg eval

@c00w
sd-image: Add option to control sd image expansion on boot.
bef4bda 
This is supeer useful to allow the normal sd-image code to be used by
someone who wants to setup multiple partitions with a sd-image.

Currently I'm manually copying the sd-image file and modifying it
instead.
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/510

@SuperSandro2000 SuperSandro2000 merged commit ac72d9a into NixOS:master May 1, 2021
@samueldr
Copy link
Member

I'm sorry I missed this, but the postBootCommands here are not exclusively about expanding the partition.

The latter half, with nix-store --load-db will "rehydrate" the "dehydrated" store-only system on first boot if needed, when the nix-path-registration flag file is present.

Turning expandOnBoot to false will break rehydration of the system on first boot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misuzu misuzu misuzu approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@c00w @SuperSandro2000 @nixos-discourse @samueldr @misuzu