[LayoutNG] Fix anonymous-block child-available-size. #24396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic introduced for CalculateChildAvailableSize was designed to
have the correct value for an element with:
"<div style="position: relative; left: 50%; top: 50%;></div>"
E.g. the percentage based left/top would resolve against the available
size. However this broke text alignment within anonymous-blocks which
require the child-available-size to be based on the actual inline-size.
This patch uses the actual inline-size in the inline direction, but
keeps the logic for block direction.
This will mean that for postiion:relative calculations we'll use
the Percentage inline-size, and Available block-size for resolving
percentages.
Bug: 1100203
Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784323}