Scroll frag non utf8 #24411
Closed
Scroll frag non utf8 #24411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is behind a flag. And I added some JavaScript tests. Design Doc: https://docs.google.com/document/d/1TovyqqeC3HoO0A4UUBKiCyhZlQSl7jM_F7KbWjK2Gcs/edit#heading=h.7nki9mck5t64 Bug: 999091 Change-Id: I4c34d9b80fe50242c6547662040439a541b652b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810447 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#701041}
…sts to respect unhandled prompt behavior (web-platform-tests#17563)
…termittents We were assuming that in the case that the status matched expected we'd have no expected entry in the log data. But actually it was being set to None, so handle both those cases. Differential Revision: https://phabricator.services.mozilla.com/D44874 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1579168 gecko-commit: 4fe3084ae3e4ce4f20ebf6c0cf333381ac93a0c8 gecko-integration-branch: central gecko-reviewers: maja_zf
Bug: 900581 Change-Id: I996882864b4e4aaf5d1f3e4a4d904d488898a6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830921 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701096}
Bug: 900581 Change-Id: I13e9433c00bf606f4d7258c76609cdb84e8b0b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831264 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701099}
Following updates in the spec, see https://w3c.github.io/webappsec-trusted-types/dist/spec/#should-block-sink-type-mismatch. Change-Id: Ia3622696068aaaa74cca7c1e08e475edd6b75016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829382 Commit-Queue: Stefano Sanfilippo <ssanfilippo@chromium.org> Reviewed-by: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#701109}
Bug: 900581 Change-Id: I9d1c84c30f630eae5001abef60af03d827436512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831261 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701122}
In particular, at top-level too, the computation should be about origins, not URLs, to resolve about:blank and to stop fighting with sandbox. Bug: 911299 Change-Id: I2d1b05b597ec7c5062f7beb320ccc3384e22cf82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816656 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701142}
This is a reland of 3dd95e215bbb616913239ed37e61d15e894cf561 The payment_method_change_response is not renamed in the reland since clank repository is using PaymentMethodChangeResponse. The rename will be landed in a separate cl. Original change's description: > [Payments] Enable shipping and contact info delegation [4/5] > > This cl implements shipping address/option change events for PH. With > this change payment handlers can notify the merchant when the user > changes the selected shipping address/option, and wait for updated > details (e.g. new shipping cost, etc) from merchant. > > For overall flow please check > https://chromium-review.googlesource.com/c/chromium/src/+/1779003 > > Bug: 984694 > Change-Id: Id881ba22bf4c846a4570801bacc49e5d4e89a72b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804557 > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#700238} Bug: 984694 Change-Id: I9a1a84e56701287eb3625b6a681a3f346c47a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828101 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701255}
A recent commit introduced a new file which influences the integration tests for the WPT CLI [1]. Update the test accordingly. [1] 809afab
ChromeDriver will no longer pass --ignore-certificate-error by default and users need to explicitly request the acceptInsecureCerts capability. https://crbug.com/chromedriver/3148
This CL migrates code to the new BrowserInterfaceBroker class for the TextDetection, BarcodeDetectionProvider and FaceDetectionProvider mojo interfaces. This allows retrieving the remote implementation from the renderer process without relying on FrameClient's InterfaceProvider. Bug: 955171, 978694, 936482 Change-Id: I8772caa7877bc9d5ee14043dba87c59a4e9fbd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826782 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#701312}
Just a testcase, because the bug cannot be fixed at this time. Aborted attempt to fix this is at: https://chromium-review.googlesource.com/c/chromium/src/+/1820177/4 Bug: 1007065 Change-Id: I44195ec77cc8b0924c81a567a9505e8a77f7d492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829878 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#701345}
For both the head poses and input poses, send this value through mojo from the device process to the renderer process on every frame. Bug: 969131 Change-Id: Ie895deb75bddb6dd883d09828cfcb30f335d3793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825478 Auto-Submit: Jacob DeWitt <jacde@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701389}
Bug: 900581 Change-Id: I21076e39559d9cc1bf90c567dcab5ac5e7cb6268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832295 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701393}
Bug: 900581 Change-Id: I694137d193dcc456034e6ca7dc7d8aadbe68b250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832146 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701394}
This reverts commit 8be89ae08126913ff4447927ac5a087b8d6babcf. Reason for revert: Build failure: https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/79827 [4142/15096] CXX obj/device/vr/vr/openxr_controller.obj FAILED: obj/device/vr/vr/openxr_controller.obj C:\b\s\w\ir\cache\goma\client\gomacc.exe ..\..\third_party\llvm-build\Release+Asserts\bin\clang-cl.e...(too long) ../../device/vr/openxr/openxr_controller.cc(204,19): error: no member named 'emulated_position' in 'device::mojom::XRInputSourceDescription' description_->emulated_position = false; ~~~~~~~~~~~~ ^ 1 error generated. Original change's description: > Update emulated position on each XRFrame > > For both the head poses and input poses, send this value through mojo > from the device process to the renderer process on every frame. > > Bug: 969131 > Change-Id: Ie895deb75bddb6dd883d09828cfcb30f335d3793 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825478 > Auto-Submit: Jacob DeWitt <jacde@chromium.org> > Commit-Queue: Will Harris <wfh@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Alexander Cooper <alcooper@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701389} TBR=dcheng@chromium.org,wfh@chromium.org,klausw@chromium.org,jacde@chromium.org,alcooper@chromium.org Change-Id: I91ec66842b8f0a14bcb85145843fb4d617847066 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 969131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833005 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701401}
…subgridded axis. Differential Revision: https://phabricator.services.mozilla.com/D46895 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1581106 gecko-commit: 91d2317a3e6416a60737ef61fc834a20a62ec082 gecko-integration-branch: autoland gecko-reviewers: emilio
Bug: 1009129 Change-Id: Iea0ee4259c894db49a76f8f4e1ca9b53f95f69ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829296 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#701468}
I added three tests. - empty input - splitting a chunk - check the output really is Uint8Array Bug: 999091 Change-Id: Ifa4374f85d02150ea2059f6190df71f420467151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831958 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Canon Mukai <canonmukai@google.com> Cr-Commit-Position: refs/heads/master@{#701489}
The argument is documented as "Chrome browser channel" and isn't used here because Chrome isn't involved.
The specification added a step to increase sizes to accommodate spanning items crossing flexible tracks instead of ignoring their contents completely. This is done after handling all grid items that don't cross such tracks, and this time items are considered together, not grouped by their span size. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items BUG=935102 TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html Change-Id: Ic91a2eb471fae23cde1570c461f491cd5335d771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492337 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Sergio Villar <svillar@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#705228}
This test tests UA-specific behavior; see web-platform-tests#19557 Bug: None Change-Id: I650dfa3c59488ad44c4b91f70be5144fd56f6024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856860 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#705296}
…#19652) The "before" property is only present in the "Push" GitHub Event [1]. Because of this, the script could not correctly detect changes when running in response to a "Pull Request" GitHub Event [2]. Remove the file filtering logic from the Bash script and instead rely on the equivalent functionality as provided by GitHub Actions [3]. [1] https://developer.github.com/v3/activity/events/types/#pushevent [2] https://developer.github.com/v3/pulls/ [3] https://help.github.com/en/articles/workflow-syntax-for-github-actions#onpushpull_requestpaths
Note: not support sub-records yet. The corresponding spec changes: w3c/web-nfc#278 w3c/web-nfc#326 and the relevant issue: w3c/web-nfc#331 BUG=520391,995234 Change-Id: I5b99543bddf505975567ecad22c0d5390842337f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1791533 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#705377}
If a mutation of the 'end' attribute ended up introducing an offset value that was before or at the begin time for the current interval, we'll no longer have a valid interval (unresolved active duration). In this case do what ResolveInterval() does and discard the current interval. Bug: 1013365 Change-Id: I871c2c235f179dabb31c2347c47f83c53d44b1d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855963 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#705397}
Differential Revision: https://phabricator.services.mozilla.com/D45580 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175 gecko-commit: 171c70db54de024df49059cb35bb6be68d5829a7 gecko-integration-branch: autoland gecko-reviewers: jfkthame
…t from the parent's. Without this patch, the `CHECK_BLOCK_AND_LINE_DIR` soft assertion in nsFloatManager can be triggered with wm-propagation-body-dynamic-change-002.html added in Part 3. Add the test as a crashtest because web-platform reftest doesn't seem to catch our soft assertions. Add reftests to verify that BFC bits are added to the child block if the parent and child has the same block-direction, but different sideways bit; also, add reftests to ensure that "text-orientation: sideways" doesn't add BFC bits. Differential Revision: https://phabricator.services.mozilla.com/D45912 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1102175 gecko-commit: c42855b477b170876a13ae32a60032d06698814c gecko-integration-branch: autoland gecko-reviewers: jfkthame
Calling `reset()` at the end of every test to close the modal dialog will only be invoked if the test passes. If an expectation fails, the call to `reset()` will never run and the dialog will remain modally open on the page. This causes all further tests to fail because calling `showModal()` on the dialog while it is open is an error. Instead, set up `reset()` to be called as a cleanup after every test regardless of whether the test passes or fails.
The `add_cleanup()` calls need to be registered outside of the `assert_throws` block to ensure that the dialogs are actually closed.
… value correctly for subgrid. This implements the resolution and adds WPTs for: w3c/csswg-drafts#4362 Differential Revision: https://phabricator.services.mozilla.com/D49027 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1234311 gecko-commit: 2ac943ae442445f96f5a68d5298b320f30b1313a gecko-integration-branch: autoland gecko-reviewers: dholbert
…-size.
Per the css-contain specification, size contained elements must be sized as if
they were empty. Up until now, we've been handling that by just using "0" as
the intrinsic size of some components, but that doesn't actually match the size
of a "true" empty select, which has some nonzero width from:
(a) the default inline-axis padding on the display frame (added in a rule for
the ::-moz-display-comboboxcontrol-frame pseudo, in forms.css).
(b) the width (inline-size) of the display frame's "placeholder" space
character, which has a small intrinsic width (but which really only exists
for *block-axis* sizing and alignment, when no option is selected from
the dropdown).
This patch addresses issue (a) by explicitly adding the display frame's
inline-axis padding to size-contained elements, and it addresses issue (b) by
changing to use a zero-width space character in empty select elements.
So: as of this patch, size-contained select elements are getting a little wider
(to address (a)), and empty select elements are also getting a little skinnier
(to address (b)), and they'll end up being the same width.
(I chose U+FEFF "zero-width non-breaking-space" since we were previously using
a non-breaking space character. I'm not sure if the non-breaking aspect matters,
but I figured I'd preserve that to be on the safe side.)
Differential Revision: https://phabricator.services.mozilla.com/D48791
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1562057
gecko-commit: 25d95be82e953bfe3758acb96c3fb80b9b602f5a
gecko-integration-branch: autoland
gecko-reviewers: TYLin
…e list items. Differential Revision: https://phabricator.services.mozilla.com/D48346 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1581467 gecko-commit: 36ab7b5bb1859ce4c084f8ee9e52aa1d381e769f gecko-integration-branch: autoland gecko-reviewers: mats
…-platform-tests#19384) Test font-optical-sizing and font-language-override parsing. https://drafts.csswg.org/css-fonts-4/#property-index
inset-block sets inline-block-start and inline-block-end scroll-margin-inline sets scroll-margin-inline-start/end etc.
NG fragments don't support collapsed borders yet. This manifested with background-clip. When the position/size of the clipped background was determined, the cells' full borders were used, not half of the winning border as is correct in collapsed mode. Bug: 1008400 Change-Id: I53a80c88d854136e8d3f540fe7b8c969152aad13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858519 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#705454}
There have been some concerns regarding the precision of readouts from the Ambient Light Sensor. To decrease the entropy, we are rounding off the illuminance value to the nearest 50 Lux to mitigate the known attack vectors as summarized in [1]. [1] w3c/ambient-light#13 (comment) This CL is based on https://chromium-review.googlesource.com/c/chromium/src/+/1695412 by Rijubrata Bhaumik and myself. Bug: 642731, 606766 Change-Id: I85449bdb835e8486b080fc269938b6c96f000c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834346 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#705486}
…tform-tests#19668) The CI builds do nothing for most branches and create a lot of no-op builds in the Azure DevOps UI, making it harder to find the real ones. PR builds are not affected by this.
This is done in order to improve compatibility with Python3
This is done in order to improve compatibility with Python3
Fixes web-platform-tests#19380. Running faster increases the risk that the GitHub search API can't find the pull request yet, so add retry.py with a --delay value that with 5 iterations adds up to a total of 15 minutes waiting.
* add test for CSS grid align-content property
This CL renames NDEFRecord methods "toText()" to "text()", "toJSON()" to "json()", and "toArrayBuffer()", to "arrayBuffer() as decided at w3c/web-nfc#370 Change-Id: I8a540ee68b34863e09df562c2075e0d3c786462a Bug: 520391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855921 Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#705531}
…eb-platform-tests#19595) Previously a Dockerfile based on Debian was added for WebKitGTK testing with the idea of reusing the built products that build.webkit.org is producing. That was done with the idea of having dozens of new nightly builds available at a day, which doesn't seem to match the needs for WPT testing/runs. It seems that having one new nightly a day (or even two a week) is more than enough. At that rate is more than reasonable to do new builds for testing with Ubuntu 18.04. And it seems that harmonizing the testing of the Linux based browsers on the same docker image has several benefits, including making easier future maintenance. This switchs the WebKitGTK testing to using Ubuntu 18.04.
…-platform-tests#19595) The nighly channel downloads the last nightly tarball available at https://webkitgtk.org/built-products and installs it on taskcluster when the test start. This tarball is generated using the webkitgtk internal JHBuild, that builds several third-party libraries needed for webkitgtk layout tests and then builds webkitgtk on top of this libraries. Because of this using this tarball requires installing quite a lot of extra dependencies (that are needed by this extra third-party libraries). A script is included inside the tarball to install this dependencies.
|
Something went wrong, forget.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.