Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joplin-desktop: 1.0.216 -> 1.0.233 #91948

Merged
merged 4 commits into from Aug 3, 2020

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented Jul 1, 2020

Motivation for this change
  1. Joplin Update to 1.0.227. This release includes the new CodeMirror Editor.
  2. Security Fix CVE-2020-15844
  3. App Icon did not work. Fixed

Since I had no glue how to fix (2), i borrowed the idea from another nix package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CheariX CheariX changed the title <!-- To help with the large amounts of pull requests, we would appreciate your reviews of other pull requests, especially simple package updates. Just leave a comment describing what you have tested in the relevant package/service. Reviewing helps to reduce the average time-to-merge for everyone. Thanks a lot if you do! List of open PRs: https://github.com/NixOS/nixpkgs/pulls Reviewing guidelines: https://hydra.nixos.org/job/nixpkgs/trunk/manual/latest/download/1/nixpkgs/manual.html#chap-reviewing-contributions --> joplin-desktop: 1.0.216 -> 1.0.224 Jul 1, 2020
@ofborg ofborg bot requested a review from HugoReeves July 2, 2020 01:34
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built successfully on NixOS. LGTM

@CheariX
Copy link
Contributor Author

CheariX commented Jul 13, 2020

1.0.227 has been released. I added a commit for this

@ofborg ofborg bot requested a review from HugoReeves July 13, 2020 09:21
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to build and test this right now but LGTM. Can be merged.

@CheariX CheariX changed the title joplin-desktop: 1.0.216 -> 1.0.224 joplin-desktop: 1.0.216 -> 1.0.227 Jul 14, 2020
@CheariX CheariX changed the title joplin-desktop: 1.0.216 -> 1.0.227 joplin-desktop: 1.0.216 -> 1.0.233 Aug 3, 2020
@ofborg ofborg bot requested a review from HugoReeves August 3, 2020 10:44
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@infinisil infinisil merged commit 396c161 into NixOS:master Aug 3, 2020
@CheariX CheariX deleted the joplin-desktop-1.0.224 branch August 5, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants