[WPT] Introduce a test-only-api helper script #24400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 30, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2276652
branch
2 times, most recently
from
95c9418
to
457f3a0
Compare
including a helper function to load Mojo JS bindings. This will enable us to have better control over loading of *.mojom.js (notably disable automatic dependency loading) and reduce code duplication. Refactor WebXR tests to use this helper script, and add missing dependencies that were previously auto loaded. (WebUSB & WebBluetooth changes to follow.) Note that upstream WPT still does not have *.mojom.js available so tests will continue to fail there (but with a clearer error). Test results on Chromium waterfall should not change. Bug: 1094512 Change-Id: If660c4788c185bc7baf9ce6edbb691333e509d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276652 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#786746}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2276652
branch
from
457f3a0
to
399c5ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including a helper function to load Mojo JS bindings. This will enable
us to have better control over loading of *.mojom.js (notably disable
automatic dependency loading) and reduce code duplication.
Refactor WebXR tests to use this helper script, and add missing
dependencies that were previously auto loaded. (WebUSB & WebBluetooth
changes to follow.)
Note that upstream WPT still does not have *.mojom.js available so tests
will continue to fail there (but with a clearer error). Test results on
Chromium waterfall should not change.
Bug: 1094512
Change-Id: If660c4788c185bc7baf9ce6edbb691333e509d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276652
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786746}