Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jellyfin-mpv-shim: 1.4.2 -> 1.5.11 #91935

Merged
merged 3 commits into from Jul 22, 2020

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Jul 1, 2020

Motivation for this change

Update to lastest release. Upstream does provide a "desktop" client which needs additional packages which i am currently not able to package - so i just updated the basic mpv-shim.

Also updated the python-mpv-jsonipc and jellyfin-apiclient-python to the latest version (at least 1.1.9 / 1.5.1 required by mpv-shim).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
6 packages updated:
jellyfin-mpv-shim (1.4.2 → 1.5.11) plex-mpv-shim python37Packages.jellyfin-apiclient-python (1.4.0 → 1.5.1) python37Packages.python-mpv-jsonipc (1.1.8 → 1.1.11) python38Packages.jellyfin-apiclient-python (1.4.0 → 1.5.1) python38Packages.python-mpv-jsonipc (1.1.8 → 1.1.11)

6 packages built:
jellyfin-mpv-shim plex-mpv-shim python37Packages.jellyfin-apiclient-python python37Packages.python-mpv-jsonipc python38Packages.jellyfin-apiclient-python python38Packages.python-mpv-jsonipc
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/087c4jsh4gxn006qj1f0f2nhiygf3w92-python3.8-python-mpv-jsonipc-1.1.8	  119876632
/nix/store/sqj9rqag2lvqx4wjl81svyyf0sjzyb60-python3.8-jellyfin-apiclient-python-1.4.0	  119620968
/nix/store/3w4kif2r8fflj2jn1znrpihannp6mfiz-jellyfin-mpv-shim-1.4.2	  365533408

/nix/store/sv60yr02phy4wdvm2sjlcn97cy7nw8dg-python3.8-python-mpv-jsonipc-1.1.11	  119854704
/nix/store/5s6qd6fg0zrdq3cx4vhxcwb294kz97cg-python3.8-jellyfin-apiclient-python-1.5.1	  119620960
/nix/store/rnp107rfcs3rqvxfi06qf0xfbrdx0mky-jellyfin-mpv-shim-1.5.11	  365598440

@colemickens
Copy link
Member

s/jellyin/jellyfin/g in the pr title and commits.

@jojosch jojosch changed the title jellyin-mpv-shim: 1.4.2 -> 1.5.10 jellyfin-mpv-shim: 1.4.2 -> 1.5.10 Jul 2, 2020
@jojosch jojosch changed the title jellyfin-mpv-shim: 1.4.2 -> 1.5.10 jellyfin-mpv-shim: 1.4.2 -> 1.5.11 Jul 22, 2020
@dywedir
Copy link
Member

dywedir commented Jul 22, 2020

Thanks!

@dywedir dywedir merged commit cf46edf into NixOS:master Jul 22, 2020
@jojosch jojosch deleted the jellyfin-mpv-shim_1.5.10 branch July 22, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants