a2jmidid: fix compilation on aarch64-linux #91920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
suggested changes
Jul 1, 2020
There was a problem hiding this comment.
- Diff LGTM
- Commits need squashed together, shouldn't be separate
- Builds fine locally
- Doesn't run cleanly locally, probably b/c I don't have the proper hardware?? Log:
[nix-shell:~/.cache/nixpkgs-review/pr-91920]$ a2jmidid
Directory "/home/.../.log" does not exist. Creating...
Directory "/home/.../.log/a2j" does not exist. Creating...
Directory "/home/.../.config/a2j" does not exist. Creating...
JACK MIDI <-> ALSA sequencer MIDI bridge, version 8 () built on Wed Dec 31 19:00:00 1969
Copyright 2006,2007 Dmitry S. Baikov
Copyright 2007,2008,2009,2011,2012 Nedko Arnaudov
Bridge starting...
Using JACK server 'default'
Hardware ports will not be exported.
ALSA lib seq_hw.c:466:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory
ERROR: a2j_new: failed to open alsa seq
ERROR: a2j_start: a2j_new() failed.
|
Hi, yes, you need an ALSA sequencer (MIDI) device for this program to work, which is precisely what the error message tells you. Thanks for the review! |
drewrisinger
approved these changes
Jul 2, 2020
0x4A6F
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
- working on a RPi 4:
[root@dca63203d971:~]# /nix/store/pvc43db7p1scq2z5zjl7c8hlz2x3xwp9-a2jmidid-8/bin/a2jmidid
Directory "/root/.log" does not exist. Creating...
Directory "/root/.log/a2j" does not exist. Creating...
Directory "/root/.config/a2j" does not exist. Creating...
JACK MIDI <-> ALSA sequencer MIDI bridge, version 8 () built on Thu Jan 1 00:00:01 1970
Copyright 2006,2007 Dmitry S. Baikov
Copyright 2007,2008,2009,2011,2012 Nedko Arnaudov
Bridge starting...
Using JACK server 'default'
Hardware ports will not be exported.
Bridge started
Press ctrl-c to stop the bridge
port created: Midi Through [14] (capture): Midi Through Port-0
port created: Midi Through [14] (playback): Midi Through Port-0
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to use the services.jack on a raspberrypi (aarch64) system and a2jmidid not building on that system kept me from doing that. So I fixed it. I cherry picked a diff from the commit that fixed this in the project's repository.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)