Fix clip state of synthetic effect for non-backdrop effects #24398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 30, 2020
This fixes a regression caused by crrev.com/c/2183198. We should move the effect's clip to the outer synthetic effects for backdrop effects only. For non-backdrop effect we don't move effect up into the synthetic effect and can share the synthetic effect with other effects, so we should not move up the clip. Bug: 1099234 Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784097}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2272122
branch
from
e2a284a
to
ffb9229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused by crrev.com/c/2183198.
We should move the effect's clip to the outer synthetic effects
for backdrop effects only. For non-backdrop effect we don't move effect
up into the synthetic effect and can share the synthetic effect with
other effects, so we should not move up the clip.
Bug: 1099234
Change-Id: I5dbd63f7c94717e42572342371df6de8fe89308e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272122
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784097}