Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc810x: remove obsolete overrides (1/x) #91945

Merged
merged 1 commit into from Jul 3, 2020

Conversation

svmhdvn
Copy link
Contributor

@svmhdvn svmhdvn commented Jul 1, 2020

Motivation for this change

Remove obsolete overrides on the following haskellPackages:

async: -doJailbreak
ChasingBottoms: -doJailbreak
ed25519: -doJailbreak
email-validate: -doJailbreak

Part of #86500

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 1, 2020

@GrahamcOfBorg build haskell.packages.ghc8101.async
@GrahamcOfBorg build haskell.packages.ghc8101.base-noprelude
@GrahamcOfBorg build haskell.packages.ghc8101.ChasingBottoms
@GrahamcOfBorg build haskell.packages.ghc8101.ed25519
@GrahamcOfBorg build haskell.packages.ghc8101.email-validate

@cdepillabout
Copy link
Member

@svmhdvn Ah, it looks like base-noprelude is failing to compile here. Maybe this doJailbreak is still needed?

@svmhdvn svmhdvn force-pushed the ghc810x-o1 branch 2 times, most recently from 0d4bc1a to b6c03f1 Compare July 2, 2020 15:37
async: -doJailbreak
ChasingBottoms: -doJailbreak
ed25519: -doJailbreak
email-validate: -doJailbreak
@svmhdvn
Copy link
Contributor Author

svmhdvn commented Jul 2, 2020

Thanks for the catch, I'll leave doJailbreak on.

@GrahamcOfBorg build haskell.packages.ghc8101.async
@GrahamcOfBorg build haskell.packages.ghc8101.ChasingBottoms
@GrahamcOfBorg build haskell.packages.ghc8101.ed25519
@GrahamcOfBorg build haskell.packages.ghc8101.email-validate

@cdepillabout
Copy link
Member

LGTM, thanks for fixing this up

@cdepillabout cdepillabout merged commit 4e22e03 into NixOS:haskell-updates Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants