python3Packages.qiskit: 0.19.1 -> 0.19.6 #91941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue with hash lookup that failed on python3.8.
Newly breaking due to changes in pytest-flake8, resolved with upstream patch. Took the opportunity to clean up the package a little bit too, remove unnecessary patch.
Imports were out of date. v0.3.0 no longer supports python2.
Reasons: Last update was Oct 2018 (no activity on GitHub since), failed tests don't error out the build (i.e. failed build can still succeed), and this package has not been kept updated to reflect the changing python3Packages.qiskit API.
drewrisinger
force-pushed
the
dr-pr-qiskit-bump
branch
from
2c4b6a2
to
88916bf
Compare
|
@GrahamcOfBorg eval |
|
Result of |
jonringer
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 91941 1
29 packages marked as broken and skipped:
- digitalbitbox - gdata-sharp - glibcCross - iterm2 - linuxPackages_4_4.evdi - linuxPackages_hardkernel_4_14.bcc - linuxPackages_hardkernel_4_14.bpftrace - linuxPackages_hardkernel_4_14.can-isotp - linuxPackages_hardkernel_4_14.chipsec - linuxPackages_hardkernel_4_14.digimend - linuxPackages_hardkernel_4_14.evdi - linuxPackages_hardkernel_4_14.mba6x_bl - linuxPackages_hardkernel_4_14.nvidia_x11 - linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 - linuxPackages_hardkernel_4_14.nvidiabl - muslCross - newlibCross - php73Packages.phpmd - php74Extensions.pcs - php74Extensions.pthreads - python27Packages.caffe - python27Packages.libmodulemd - python37Packages.nixpart - python37Packages.notify - python37Packages.qasm2image - python38Packages.libselinux - python38Packages.nixpart - python38Packages.notify - python38Packages.qasm2image27 packages built:
- python37Packages.cairosvg - python37Packages.cssselect2 - python37Packages.pygal - python37Packages.qiskit - python37Packages.qiskit-aer - python37Packages.qiskit-aqua - python37Packages.qiskit-ibmq-provider - python37Packages.qiskit-ignis - python37Packages.qiskit-terra - python37Packages.retworkx - python37Packages.tinycss2 - python37Packages.weasyprint - python37Packages.xml2rfc - python38Packages.cairosvg - python38Packages.cssselect2 - python38Packages.pygal - python38Packages.qiskit - python38Packages.qiskit-aer - python38Packages.qiskit-aqua - python38Packages.qiskit-ibmq-provider - python38Packages.qiskit-ignis - python38Packages.qiskit-terra - python38Packages.retworkx - python38Packages.tinycss2 - python38Packages.weasyprint - xml2rfc (python38Packages.xml2rfc) - sourcehut.metasrht
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest version of qiskit. https://github.com/Qiskit/qiskit/releases. Update associated/component packages.
Unbreaks the packages. There were some issues caused by the update to python38 as default interpreter that I apparently didn't handle properly in
python38Packages.retworkx.NOTE: I generally update to the latest in my NUR channel within a few days, but the nixpkgs version lags a little.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)