Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpromhttp: init at 0.1.1, build in combination with libprom #91908

Merged
merged 1 commit into from Jul 9, 2020
Merged

libpromhttp: init at 0.1.1, build in combination with libprom #91908

merged 1 commit into from Jul 9, 2020

Conversation

purcell
Copy link
Member

@purcell purcell commented Jul 1, 2020 •
edited

Motivation for this change

This is an alternative formulation of #91323, to eliminate duplication of the source spec w.r.t. its sister library libprom (added in #90706).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@purcell
Copy link
Member Author

purcell commented Jul 1, 2020

/cc @cfsmp3

@ofborg ofborg bot requested a review from cfsmp3 July 1, 2020 02:05
@purcell purcell mentioned this pull request Jul 1, 2020
Closed
6 tasks
cole-h
cole-h approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. One nit, though.

[2 built, 2 copied (0.2 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/91908
1 package built:
libpromhttp

pkgs/development/libraries/prometheus-client-c/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from cfsmp3 July 2, 2020 05:27
@purcell
Copy link
Member Author

purcell commented Jul 8, 2020

This should be ready to merge now, afaict.

@grahamc grahamc merged commit cb330da into NixOS:master Jul 9, 2020
@purcell
Copy link
Member Author

purcell commented Jul 9, 2020

Thanks @grahamc and @cole-h!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@cfsmp3 cfsmp3 Awaiting requested review from cfsmp3

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@purcell @cfsmp3 @cole-h @grahamc